Skip to content

#1500: Remove any types from AppMain.test.tsx#2035

Merged
RChandler234 merged 1 commit intodevelopfrom
#1500-Remove-any-type-from-AppMain.test.tsx
Jan 31, 2024
Merged

#1500: Remove any types from AppMain.test.tsx#2035
RChandler234 merged 1 commit intodevelopfrom
#1500-Remove-any-type-from-AppMain.test.tsx

Conversation

@vindema
Copy link
Copy Markdown
Contributor

@vindema vindema commented Jan 31, 2024

Changes

Replaced the any type in AppMain.test.tsx with React.ReactNode

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #1500

@vindema vindema requested a review from jackturner106 January 31, 2024 15:11
@vindema vindema self-assigned this Jan 31, 2024
Copy link
Copy Markdown
Contributor

@jackturner106 jackturner106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RChandler234 RChandler234 merged commit d20145f into develop Jan 31, 2024
@RChandler234 RChandler234 deleted the #1500-Remove-any-type-from-AppMain.test.tsx branch January 31, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactoring] - Remove any type from src\frontend\src\tests\app\AppMain.test.tsx

3 participants