Skip to content

#2028 use delete design review hook#2226

Merged
walker-sean merged 5 commits intodevelopfrom
#2028-delete-design-review-hook
Mar 20, 2024
Merged

#2028 use delete design review hook#2226
walker-sean merged 5 commits intodevelopfrom
#2028-delete-design-review-hook

Conversation

@bderbs30
Copy link
Copy Markdown
Contributor

@bderbs30 bderbs30 commented Mar 19, 2024

Changes

hook and api for deleteDesignReview

Screenshots

After using the delete icon / modal
image

image

image

To Do

  • add button on the design review to actually delete it

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2028

@bderbs30 bderbs30 self-assigned this Mar 19, 2024
@bderbs30 bderbs30 requested a review from RChandler234 March 20, 2024 02:47
Copy link
Copy Markdown
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walker-sean walker-sean merged commit 45dc328 into develop Mar 20, 2024
@walker-sean walker-sean deleted the #2028-delete-design-review-hook branch March 20, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design Review Calendar - Use Delete Design Review

2 participants