Skip to content

Conversation

@thaninbew
Copy link
Contributor

@thaninbew thaninbew commented Nov 16, 2024

Changes

Merged new changes from Aaryan and added onboarding block

Notes

Lmk if this aligns more with what's needed! Also, am I supposed to be editing and updating the PR comment or should i create a new PR everytime?

Screenshots

If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window

image
image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • [x ] No linting errors / newline at end of file warnings
  • [x ] All code follows repository-configured prettier formatting
  • [ x] No merge conflicts
  • [x ] All checks passing
  • [x ] Screenshots of UI changes (see Screenshots section)
  • [x ] Remove any non-applicable sections of this template
  • [ x] Assign the PR to yourself
  • [x ] No yarn.lock changes (unless dependencies have changed)
  • [x ] Request reviewers & ping on Slack
  • [x ] PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)
#2983

@thaninbew thaninbew requested a review from Aaryan1203 November 16, 2024 21:39
@thaninbew thaninbew self-assigned this Nov 16, 2024
@thaninbew thaninbew changed the base branch from develop to feature/recruitment_and_onboarding November 16, 2024 21:40
text: string;
}

const OnboardingBlock: React.FC<OnboardingBlockProps> = ({ title, text }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the organization for the code and creating a new file for this block. What I think might be a better idea is to use grid to create three sections (And you can leave placeholder comment for the other two blocks like useful links and questions block) and then just add the styling for your text and block there. This way we won't have a different component for the onboarding block, useful links, and questions and instead itll all be in one file

@thaninbew thaninbew requested a review from Aaryan1203 November 17, 2024 06:11
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@Aaryan1203 Aaryan1203 merged commit ead319b into feature/recruitment_and_onboarding Nov 20, 2024
@Aaryan1203 Aaryan1203 deleted the #2983-onboarding-create-onboarding-block branch November 20, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants