Skip to content

Conversation

@staysgt
Copy link
Contributor

@staysgt staysgt commented Nov 19, 2024

Changes

Added name to credits page

Notes

Went well

Screenshots

Screenshot 2024-11-25 at 5 34 40 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3020

@staysgt staysgt requested a review from wavehassman November 19, 2024 19:23
@staysgt staysgt self-assigned this Nov 19, 2024
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update your PR to have a screenshot of the UI (the credits page), instead of the code?

@staysgt staysgt requested a review from walker-sean November 25, 2024 22:37
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stunning!

@walker-sean walker-sean merged commit ea4f0ea into develop Nov 29, 2024
4 checks passed
@walker-sean walker-sean deleted the #3020-SarahTaylor-credits branch November 29, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sarah Taylor - Credits

3 participants