Skip to content

Conversation

@justalittlemushroom
Copy link
Contributor

@justalittlemushroom justalittlemushroom commented Nov 20, 2024

…YY-MM-DD to MM-DD-YYYY

Changes

Changed the Start Date Request for a Work Package Form from YYYY-MM-DD to MM-DD-YYYY

Screenshots

Screenshot 2024-11-20 at 19 58 26 Screenshot 2024-11-20 at 19 58 29

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2684

Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the end date one as well sorry

vsp05
vsp05 previously approved these changes Nov 21, 2024
@vsp05 vsp05 self-requested a review November 21, 2024 00:45
@vsp05
Copy link
Contributor

vsp05 commented Nov 21, 2024

make sure to not push your yarn.lock changes! otherwise, looks good

Copy link
Contributor

@vsp05 vsp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great Work!

@Peyton-McKee Peyton-McKee merged commit f485f26 into develop Nov 21, 2024
@Peyton-McKee Peyton-McKee deleted the 2684-work-package-form-start-date-requests-yyyy-mm-dd-but-takes-mm-dd-yyyy branch November 21, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Work Package Form - Start Date Requests YYYY-MM-DD but takes MM-DD-YYYY

4 participants