Skip to content

Conversation

@Josh0011
Copy link
Contributor

@Josh0011 Josh0011 commented Dec 3, 2024

Changes

added my name to the credits

Notes

None

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3025

@Josh0011 Josh0011 self-assigned this Dec 3, 2024
Copy link
Contributor

@vsp05 vsp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vsp05 vsp05 requested review from walker-sean and removed request for Peyton-McKee December 5, 2024 00:41
@walker-sean walker-sean merged commit d7dfc53 into develop Dec 11, 2024
4 checks passed
@walker-sean walker-sean deleted the #3025-JoshuaSharma-credits branch December 11, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Joshua Sharma - Credits

4 participants