#3143 Removed arrows on Add SABO # #3177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great work! Would you be able to look into why the modal changes size when you start typing in it? Otherwise, looks good. |
Contributor
|
Good work! Sorry to bug you with all these additional features, but I noticed when you add a SABO number, it doesn't update on the reimbursement request page until you refresh the page. You can use react hooks to make it automatically update when the addSABONumberModal is submitted. Do you think you could work on that? Sorry lol |
…b.com/Northeastern-Electric-Racing/FinishLine into #3143-Get-rid-of-arrows-on-Add-SABO-#
vsp05
approved these changes
Feb 9, 2025
Contributor
vsp05
left a comment
vsp05
left a comment
There was a problem hiding this comment.
LGTM! Great work! Thanks for noticing those other issues too, I created a bug ticket for those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed arrows in text field for Add SABO # and removed 0 as default value
Screenshots
Checklist
yarn.lockchanges (unless dependencies have changed)Closes #3143