Skip to content

Conversation

@cielbellerose
Copy link
Contributor

@cielbellerose cielbellerose commented Feb 4, 2025

Changes

Retrieves all part review FAQS in the current organization

Screenshots

Screenshot 2025-02-10 at 9 15 25 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3170

@cielbellerose cielbellerose requested a review from chpy04 February 4, 2025 21:09
@cielbellerose cielbellerose self-assigned this Feb 4, 2025
@cielbellerose cielbellerose linked an issue Feb 4, 2025 that may be closed by this pull request
3 tasks
@cielbellerose cielbellerose changed the base branch from develop to feature/cad-project-file-review February 4, 2025 21:09
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good so far! Just need to write some tests and then include postman screenshots

@cielbellerose cielbellerose requested a review from chpy04 February 11, 2025 18:47
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @walker-sean?

Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Make sure to transform the data before returning

@cielbellerose cielbellerose requested a review from chpy04 February 25, 2025 18:37
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@walker-sean walker-sean merged commit f5d9d0e into feature/cad-project-file-review Feb 26, 2025
4 checks passed
@walker-sean walker-sean deleted the 3170-create-getpartreview-faqs branch February 26, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAD/Project File Reviews] - create getPartReviewFAQs endpoint

6 participants