#3140-added-sponsor-pills #3215
Conversation
I need the sponsor_tier model.
|
Looks good! Is the screenshot of the component before the recent changes (i.e. before replacing the enum)? If so, I'll talk to the other tech leads and see if you can test the component with more types of sponsor tiers. |
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
Can you make a SponsorTier type rather than using the prisma type for this component? To do this, go into shared types and create a finance.types.ts file, within that file create interface SponsorTier with its field matching the Sponor_Tier model in the schema.
Yes the picture is from before the enum :) |
| export interface Sponsor { | ||
| sponsorId: string; | ||
| name: string; | ||
| organizationId: string; |
There was a problem hiding this comment.
We dont need info about organization here in the frontend - we're in a context that contains one organization
| organizationId: string; | ||
| organization: Organization; | ||
| dateCreated: Date; | ||
| dateDeleted?: Date; |
There was a problem hiding this comment.
Don't need this - no deleted sponsors should make it to the frontend
| activeStatus: boolean; | ||
| vendorContact: string; | ||
| tier: SponsorTier; | ||
| sponsorTierId: string; |
| name: string; | ||
| organizationId: string; | ||
| organization: Organization; | ||
| dateCreated: Date; |
There was a problem hiding this comment.
Unless we need to sort or filter by date added, we don't need this
|
|
||
| export interface SponsorTier { | ||
| sponsorTierId: string; | ||
| organization: Organization; |
There was a problem hiding this comment.
Same thing about organization stuff here
| dueDate: Date; | ||
| notifyDate?: Date; | ||
| assignee?: User; | ||
| assigneeUserId?: string; |
| assigneeUserId?: string; | ||
| notes: string; | ||
| sponsor: Sponsor; | ||
| sponsorId: string; |
Changes
Added the sponsor tier pill component.
Notes
I do not think this is done yet. I added the tiers in the sponsor tier pill file in an interface and I do not think that will be the way this gets implemented.
Screenshots
To Do
Closes #3140