Skip to content

Conversation

@vsp05
Copy link
Contributor

@vsp05 vsp05 commented Feb 21, 2025

Closes #3247

Copy link
Contributor

@jonathan-chen10 jonathan-chen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check with end user, you probably need to pass ident to the function instead of using the backend uuid

Copy link
Contributor

@jonathan-chen10 jonathan-chen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good. Can you change the wording so it seems clearer what the number is? Like "ID#{id}" or something along those lines

Copy link
Contributor

@jonathan-chen10 jonathan-chen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@vsp05 vsp05 requested a review from walker-sean April 4, 2025 02:42
@walker-sean walker-sean merged commit beb2b84 into develop Apr 4, 2025
4 checks passed
@walker-sean walker-sean deleted the #3247-include-rrid-in-slack-util branch April 4, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

include rrid in slack reimbursement request created

4 participants