#3210 - edit sponsor task endpoint #3309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great! I would maybe do postman tests for bad user id and bad sponsor id as well just to be super thorough but I'll ask Jack and Waverly to see what they think! |
dreifusjack
requested changes
Mar 19, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
Great start Sarah! Just left some small reviews, lmk if you have any questions
dreifusjack
requested changes
Mar 22, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
Just some small changes, lmk if you have any questions
dreifusjack
previously approved these changes
Mar 24, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
LGTM. Also when you fix a requested change, can you click resolve conversation? Just to clean up the pr. Thanks!
walker-sean
requested changes
Mar 25, 2025
walker-sean
requested changes
Mar 28, 2025
| if (!(await userHasPermission(submitter.userId, org.organizationId, isHead))) | ||
| throw new AccessDeniedException('Only heads can edit sponsor tasks.'); | ||
|
|
||
| const oldSponsorTask = await prisma.sponsor_Task.findUnique({ |
Member
There was a problem hiding this comment.
Search within the organization
|
|
||
| if (!oldSponsorTask) throw new NotFoundException('SponsorTask', sponsorTaskId); | ||
|
|
||
| if (assigneeUserId) { |
walker-sean
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created the editSponsorTask endpoint.
Test Cases
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3210