CAD Part History Component #3367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 3339-CAD-Part-History
… into 3339-CAD-Part-History
cielbellerose
changed the base branch from
cad/project-file-reviews
to
feature/cad-project-file-review
… into 3339-CAD-Part-History
… into 3339-CAD-Part-History
… into 3339-CAD-Part-History
gcooper407
reviewed
Apr 16, 2025
| part: Part; | ||
| } | ||
|
|
||
| const PartHistoryView: React.FC<PartHistoryViewProps> = ({ part }: PartHistoryViewProps) => { |
Contributor
There was a problem hiding this comment.
Hey I know this isn't listed as part of your ticket but any chance you could make this a scrollable component? In case histories get too long
gcooper407
requested changes
Apr 16, 2025
Contributor
gcooper407
left a comment
gcooper407
left a comment
There was a problem hiding this comment.
This is absolutely killer work, just asked for one small addition that should be simple
… into 3339-CAD-Part-History
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Component to display the full history of a given part. Created utils functions that return date and data for part creation, submission history, review request history, and review history. All entries sorted by date and returned as strings.
Notes
Submission links will eventually go to corresponding submissions part page
Test Cases
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3339