#3282 edit abbreviation table #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zwendle
reviewed
Apr 27, 2025
Contributor
Zwendle
left a comment
Zwendle
left a comment
There was a problem hiding this comment.
Nit: change SetAbbreviationModel file and component name to SetAbbreviationModal
| /> | ||
| <Typography variant="subtitle1">Project Name Abbreviations</Typography> | ||
| <AdminToolTable columns={[{ name: 'Project Name' }, { name: 'Abbreviation' }]} rows={[]} /> | ||
| <AdminToolTable columns={[{ name: 'Project Name' }, { name: 'Abbreviation' }]} rows={projectTableRows} /> |
Contributor
There was a problem hiding this comment.
Nit: After creating an abbreviation, the first cell in the right-most column doesn't have the same black border as the other cells. If you add a third { name: '' } to the columns prop that should fix the styling issue (not sure if that's the best way to fix it though lol)
walker-sean
requested changes
May 2, 2025
| } | ||
|
|
||
| /** | ||
| * Revomves the abbreviation from a given project |
| const project = await ProjectsService.getSingleProjectWithQueryArgs(wbsNum, organization); | ||
|
|
||
| if (!(await userHasPermission(user.userId, organization.organizationId, isAdmin))) { | ||
| throw new AccessDeniedAdminOnlyException('delete Abbreviation'); |
| * @returns the updated project | ||
| */ | ||
| static async setAbbreviation(wbsNum: WbsNumber, user: User, organization: Organization, abbreviation: string) { | ||
| const project = await ProjectsService.getSingleProjectWithQueryArgs(wbsNum, organization); |
Member
There was a problem hiding this comment.
Throw if the project isn't found
| * @returns the updated project | ||
| */ | ||
| static async deleteAbbreviation(wbsNum: WbsNumber, user: User, organization: Organization) { | ||
| const project = await ProjectsService.getSingleProjectWithQueryArgs(wbsNum, organization); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added features to the abbreviation table to set abbreviations (existing and new), using set and delete endpoints
Test Cases
Screenshots
Postman testing not done because you can test it with the table (add something and then refresh)
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3282