Skip to content

Conversation

@AbhinavGonthina
Copy link
Contributor

Changes

Added the PartsPage overview component

Notes

  • I created utils functions for getting a reviewer's reviewing status, review status of the part to string, and review status to color. I just have them in the PartPageOverview.tsx for now but they should probably be somewhere else if they'll be utilized elsewhere.
  • I initially tested the component in replacement of the parts review page in a specific project's page but reverted back to normal so this page will not show up unless it is placed back into some part of the frontend. The test cases in the part-review.api.ts are also reverted back to normal.

Test Cases

N/A

Screenshots

image
image
image
image
image

  • Problem: the reviewer's status (the dot) gets squished at minimum width when the sidebar is enabled. I'm not sure how to fix this.
    image

To Do

N/A

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3337

@AbhinavGonthina AbhinavGonthina self-assigned this Apr 13, 2025
@AbhinavGonthina AbhinavGonthina changed the base branch from develop to feature/cad-project-file-review April 13, 2025 14:25
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome! Just a few minor tweaks

@chpy04 chpy04 self-requested a review May 1, 2025 17:18
Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chpy04 chpy04 merged commit c84b968 into feature/cad-project-file-review May 1, 2025
4 checks passed
@chpy04 chpy04 deleted the #3337-part-overview-component branch May 1, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAD/Project File Review] - Part Overview component

3 participants