#3384 part review sidebar thing #3417

nateci · 2025-04-18T19:32:05Z

Changes

part review page
URL queries for submissions and reviews
dynamic display of submission vs review
dynamic display of review vs in progress review
displays pdfs
allows downloads
allows markups of pdfs
allows uploads for reviews
some other things

Notes

In the video I make reviews from the new button on the part page. Typically this will be done from the action button on the review, so reviewers would not have to go and find the review they just made ,but the action button is not done yet

Screenshots

I made a yt video again: https://youtu.be/ljDsP20cHNs

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

[ x] All commits are tagged with the ticket number
[ x] No linting errors / newline at end of file warnings
[ x] All code follows repository-configured prettier formatting
[ x] No merge conflicts
[ x] All checks passing
[ x] Screenshots of UI changes (see Screenshots section)
[ x] Remove any non-applicable sections of this template
[ x] Assign the PR to yourself
[ x] No yarn.lock changes (unless dependencies have changed)
[ x] Request reviewers & ping on Slack
[ x] PR is linked to the ticket (fill in the closes line below)

Closes #3384

chpy04

This looks good so far. Couple things:

first change the service function to call the google drive API function (and change that function to make sense for files other than images)
change the endpoint to just take in a file id, that way we can use it generically for submission and review files

chpy04 · 2025-04-24T19:23:08Z

src/backend/src/services/part-review.services.ts

    return deletedPopup;
  }
+
+  static async downloadSubmissionFile(submissionId: string): Promise<{ buffer: Buffer; type: string; name: string }> {


This should be very similar to downloadImage in the onboarding.service file

…er button we had so it just opens a new tab with that logic impl, saving should work deleting a file works (all backend should be hooked up).

chpy04

Lit, couple things

chpy04 · 2025-04-26T21:19:39Z

src/backend/src/services/part-review.services.ts

        notes,
-        completedAt
+        completedAt,
+        ...(fileIds !== undefined && { fileIds })


this might work but in terms of readability can you change it to fileIds ? fileIds : review.fileIds

chpy04 · 2025-04-26T21:26:04Z

src/frontend/src/components/ReviewSidebar.tsx

@@ -0,0 +1,221 @@
+import React, { useEffect, useState, useContext, useMemo } from 'react';


Put this file near our other part review frontend files, either in the folder or in a components folder within the part review folder. src/components is reserved for things that are used across the site

chpy04 · 2025-04-26T21:27:14Z

src/frontend/src/hooks/part-review.hooks.ts

  );
 };

-export const useUploadReviewFiles = (reviewId: string) => {


why is this deleted?

merge with feature

walker-sean

Bug found after trying to submit review with no files:

In-text markups will also default to common mistakes unless I click on the common mistake button and then the markup button again.

nit:

Remove this circle when hovering over the buttons on the part detail page

walker-sean · 2025-05-04T02:30:05Z

src/backend/src/services/part-review.services.ts

+    const imagedata = await uploadFile(file);
+
+    if (!imagedata?.id) {
+      throw new HttpException(500, 'could not upload image');


Nit: not necessarily an image

walker-sean · 2025-05-04T02:30:16Z

src/backend/src/controllers/part-review.controllers.ts

+  static async uploadFile(req: Request, res: Response, next: NextFunction) {
+    try {
+      if (!req.file) {
+        throw new HttpException(400, 'Invalid or undefined image data');


Nit: not necessarily an image

walker-sean · 2025-05-04T02:34:22Z

src/frontend/src/pages/PartPage/Components/CreateReviewPopup.tsx

+  commonMistakes: PartReviewCommonMistake[];
+  onDelete: () => void;
+  createPopup: (xCoord: number, yCoord: number, title: string, description?: string) => void;
+  custom: boolean;


maybe make this customComment or something

walker-sean · 2025-05-04T02:34:39Z

src/frontend/src/pages/PartPage/Components/CreateReviewPopup.tsx

+}) => {
+  const [hovering, setHovering] = useState<boolean>(false);
+  const [selelcted, setSelected] = useState<boolean>(true);
+  const [textEdittor, setTextEdittor] = useState<boolean>(custom);


spelling -- also, it would probably be better to call this showCustomTextField or something like that

walker-sean · 2025-05-04T02:35:13Z

src/frontend/src/pages/PartPage/Components/CreateReviewPopup.tsx

+  custom
+}) => {
+  const [hovering, setHovering] = useState<boolean>(false);
+  const [selelcted, setSelected] = useState<boolean>(true);


walker-sean · 2025-05-04T02:40:51Z

src/frontend/src/pages/PartPage/Components/PdfDisplay.tsx

+        <Box display="flex" alignItems="center">
+          {pdf && <DownloadButton fileId={submission.fileIds[fileIdx]} filename={`${submission.name}_${fileIdx + 1}`} />}
+          <Typography variant={'h4'}>
+            {submission.name} #{submissionIdx + 1} {review ? ' Review' : ''}


Maybe do ${submission.name} (submission #${submissionIdx + 1}.

Having a number after the name is a bit confusing

walker-sean · 2025-05-04T02:42:00Z

src/frontend/src/pages/PartPage/Components/PdfDisplay.tsx

+  );
+};
+
+export default PDFViewer;


Should we support multipage pdfs here? Currently, they can only be uploaded but only one file will be shown. Supporting multipage pdfs also means we need to track on which page popups are made

walker-sean · 2025-05-04T02:43:30Z

src/frontend/src/pages/PartPage/Components/ReviewPopup.tsx

+  newPopup
+}) => {
+  const [hovering, setHovering] = useState<boolean>(false);
+  const [selelcted, setSelected] = useState<boolean>(false);


walker-sean · 2025-05-04T02:43:34Z

src/frontend/src/pages/PartPage/Components/ReviewPopup.tsx

+}) => {
+  const [hovering, setHovering] = useState<boolean>(false);
+  const [selelcted, setSelected] = useState<boolean>(false);
+  const [editting, setEditting] = useState<boolean>(newPopup);


walker-sean · 2025-05-04T02:46:52Z

Also, we should make sure assignees and reviewers are mutually exclusive

walker-sean · 2025-05-04T19:04:10Z

src/frontend/src/pages/PartPage/Components/PdfDisplay.tsx

+              }}
+              onClick={commentOnClick}
+            >
+              <AddCommentRoundedIcon sx={{ width: '60%', height: '60%' }} />


Could you add tooltips to these icon buttons that just say their action

walker-sean · 2025-05-04T19:09:05Z

...Page/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx

            <FormLabel>File(s)</FormLabel>
            <Grid container>
-              {files.map((file, index) => {
+              {fileIds.map((file, index) => {


Could we have these extend down vertically in a list rather than horizontally?

walker-sean · 2025-05-04T19:09:19Z

...Page/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx

-                    <Typography>{displayName(file.name)}</Typography>
-                    <IconButton onClick={() => removeFile(index)}>
+                    <Typography>{displayName(files[index].name)}</Typography>
+                    <IconButton


Nit: the text and icon button are misaligned

walker-sean · 2025-05-04T19:10:05Z

...Page/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx

                Upload
                <input
                  type="file"
                  hidden


since you can have multiple files, make this a multiple file input

This still needs to be made a multiple input

walker-sean · 2025-05-04T19:14:23Z

Forgot to add: I think clicking on the part link should bring you to the latest submission/review rather than earliest

walker-sean

2 questions:

Is there utility in having a status selection when making a review or should it always become in review?
Will there be an ability to create a review from the part details page?

walker-sean · 2025-05-06T02:02:46Z

...Page/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx

                Upload
                <input
                  type="file"
                  hidden


This still needs to be made a multiple input

walker-sean · 2025-05-06T02:04:14Z

src/frontend/src/pages/PartPage/Components/PdfDisplay.tsx

+        {/* custom comment, common mistake, and file upload buttons for reviews*/}
+        {reviewMode && (
+          <Box display={'flex'} flexDirection={'column'}>
+            <Box


Add cursor: pointer to this and the following icon

chpy04 · 2025-05-06T13:30:50Z

2 questions:

Is there utility in having a status selection when making a review or should it always become in review?

Will there be an ability to create a review from the part details page?

The ability to start a review will be in the actions button that is being worked on right now in a different ticket. Once that exists we can change the status selection options. Although I am thinking that we will want the options to be review or approve with the idea that if people want to start a review with markups they will go into the part page to do that

nateci added 3 commits April 17, 2025 14:51

#3384 initial commit

58b0813

#3384 fixed sidebar, buttons should be in right place now

aa1dbd9

#3384 styling

f89f649

chpy04 requested changes Apr 24, 2025

View reviewed changes

#3384 Component is now hooked up with backend, tried to mimic the oth…

a717e73

…er button we had so it just opens a new tab with that logic impl, saving should work deleting a file works (all backend should be hooked up).

nateci marked this pull request as ready for review April 26, 2025 16:44

chpy04 requested changes Apr 26, 2025

View reviewed changes

chpy04 and others added 13 commits April 26, 2025 22:00

Merge branch 'feature/cad-project-file-review' into #3384PartReview

1914456

merge with feature

#3384 review fixes and started integration

ad4652a

#3384 merge with feature

43b6693

Merge branch 'feature/cad-project-file-review' into #3384PartReview

7c97859

merge with feature

#3384 showing part page functionality

63b9eb3

#3384 review popup functionality

e456944

#3384 review page

0eca937

#3384 bugs and comments

0718191

#3384 test fix

43b4df0

#3384 import fix

00ceecf

#3384 retrigger checks

99c44b2

#3384 maybe?

737112e

#3384 idk

13fdd89

walker-sean requested changes May 3, 2025

View reviewed changes

chpy04 added 4 commits May 3, 2025 18:42

#3384 file upload changes

6afe9f5

#3384 markup fixes

6ec5a3f

#3384 linting fixes

e92a57e

#3384 test fix maybe

4241731

walker-sean requested changes May 4, 2025

View reviewed changes

chpy04 added 3 commits May 4, 2025 06:58

#3384 multi page pdfs

f320b67

#3384 various fixes

241c4b2

#3384 assignees and reviewers mutually exclusive

1014a49

chpy04 requested a review from walker-sean May 4, 2025 11:10

walker-sean requested changes May 4, 2025

View reviewed changes

#3384 bug fixes and last page display by default

c1e2692

walker-sean requested changes May 6, 2025

View reviewed changes

chpy04 added 2 commits May 6, 2025 10:05

multiple file inputs and cursor pointer

6f15c7d

fix to load pages with no parts

0c8fd63

walker-sean approved these changes May 7, 2025

View reviewed changes

walker-sean merged commit 28054b4 into feature/cad-project-file-review May 7, 2025
4 checks passed

walker-sean deleted the #3384PartReview branch May 7, 2025 22:48

		@@ -0,0 +1,221 @@
		import React, { useEffect, useState, useContext, useMemo } from 'react';

#3384 part review sidebar thing #3417

#3384 part review sidebar thing #3417

Uh oh!

Conversation

nateci commented Apr 18, 2025 • edited by chpy04 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Screenshots

Checklist

Uh oh!

chpy04 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chpy04 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walker-sean left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walker-sean commented May 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walker-sean commented May 4, 2025

Uh oh!

walker-sean left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chpy04 commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nateci commented Apr 18, 2025 •

edited by chpy04

Loading