Skip to content

Conversation

@jonathan-chen10
Copy link
Contributor

@jonathan-chen10 jonathan-chen10 commented Apr 29, 2025

Changes

Material form now has a box to input RR. Added an endpoint to filter reimbursement requests by team.

Notes

The modal looks different from the mock because the mock was missing parts of the original modal, I only added RR#.

Screenshots

Screenshot 2025-05-16 at 2 24 21 AM Screenshot 2025-05-16 at 2 24 39 AM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3396

@jonathan-chen10 jonathan-chen10 self-assigned this Apr 29, 2025
@jonathan-chen10 jonathan-chen10 changed the base branch from develop to feature/finance-redesign April 29, 2025 20:47
@wavehassman wavehassman marked this pull request as ready for review May 14, 2025 02:27
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! A few visual things:
image

  • can we get rid of some of that excess spacing on the top?
  • conversely, we're missing space between quantity and unit
  • price should always show two decimal places

@walker-sean walker-sean merged commit 5205872 into feature/finance-redesign May 20, 2025
4 checks passed
@walker-sean walker-sean deleted the #3396-bom-link-reimbursement branch May 20, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Finance Redesign] - Add material modal + new column on BOM table for linked reimbursements

4 participants