Skip to content

Conversation

@wavehassman
Copy link
Contributor

@wavehassman wavehassman commented May 15, 2025

Changes

Changed the schema so Change and Change Request can either be wbsElement or Other Reimbursement Product Reason. I didn't change the existing endpoints since right now finance only wants a change request for editing an Other Reimbursement Product Reason budget. I created a new type of change request to edit the budget. This is the only one that takes an other reason id since that is all that is necessary right now. Fixed the frontend to allow for both. I think I got everything-> did some major clicking around.

Also made a change to the add vendor table, just made the labels bigger and bolder. This was just the easiest ticket to do it in because it is up to date.

Screenshots

Screenshot 2025-05-14 at 8 11 21 PM Screenshot 2025-05-14 at 8 11 14 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3465

@walker-sean walker-sean merged commit 032868c into feature/finance-redesign May 19, 2025
4 checks passed
@walker-sean walker-sean deleted the #3465-change-request-for-category branch May 19, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants