-
Notifications
You must be signed in to change notification settings - Fork 9
#2733 finance admin page modals #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
walker-sean
merged 17 commits into
feature/finance-redesign
from
#2733-finance-admin-page-modals
Jun 1, 2025
Merged
#2733 finance admin page modals #3470
walker-sean
merged 17 commits into
feature/finance-redesign
from
#2733-finance-admin-page-modals
Jun 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete modals and fixed edit budget modal for reason to follow new endpoint
walker-sean
requested changes
May 29, 2025
Member
walker-sean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few things:
- Could you make the Category table be labeled 'Reimbursement Categories'
- The account code field is marked as required in the category modal but it is not enforced as required
- Could you add a user-friendly error message for the parsing of number fields
- Index code doesn't have an error message when submitting the category form without one
walker-sean
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added amount to account code as Naisha requested. Set up add, edit and delete modals for account code and category.
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3383