Skip to content

Conversation

@vsp05
Copy link
Contributor

@vsp05 vsp05 commented May 16, 2025

Changes

Added amount to account code as Naisha requested. Set up add, edit and delete modals for account code and category.

Screenshots

Screenshot 2025-05-25 at 11 20 45 PM Screenshot 2025-05-25 at 11 20 49 PM Screenshot 2025-05-25 at 11 20 52 PM Screenshot 2025-05-25 at 11 20 56 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3383

@wavehassman wavehassman marked this pull request as ready for review May 26, 2025 03:01
@wavehassman wavehassman self-requested a review May 26, 2025 03:01
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few things:

  • Could you make the Category table be labeled 'Reimbursement Categories'
  • The account code field is marked as required in the category modal but it is not enforced as required
  • Could you add a user-friendly error message for the parsing of number fields
  • Index code doesn't have an error message when submitting the category form without one

@walker-sean walker-sean merged commit 377e4c0 into feature/finance-redesign Jun 1, 2025
4 checks passed
@walker-sean walker-sean deleted the #2733-finance-admin-page-modals branch June 1, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants