Skip to content

Conversation

@Mardan21
Copy link
Contributor

Changes

Added my name and favorite color to CreditsPage.tsx; also added --platform=linux/amd64 in FinishLine/package.json following docker run on line 42 (troubleshot with Vinay, needed to add this for yarn docker:dev to work for me)

Notes

Any other notes go here

Screenshots

finishline_screenshot finishline_screenshot_small

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (3473)

@Mardan21 Mardan21 requested review from Peyton-McKee and vsp05 and removed request for Peyton-McKee May 18, 2025 00:16
@Mardan21 Mardan21 self-assigned this May 18, 2025
@Mardan21 Mardan21 added the credits For the starter credits tickets label May 18, 2025
Copy link
Contributor

@vsp05 vsp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! If you don't mind, could you revert the change to package.json and just keep that change locally? (i.e. you can just add package.json to your .gitignore file)

@vsp05
Copy link
Contributor

vsp05 commented May 20, 2025

I love the animation btw lol

@vsp05
Copy link
Contributor

vsp05 commented May 26, 2025

awesome, lgtm!

@vsp05 vsp05 self-requested a review May 26, 2025 22:15
@chpy04 chpy04 merged commit 4f5cd83 into develop Jul 9, 2025
4 checks passed
@chpy04 chpy04 deleted the #3473-MardanMahmut-credits branch July 9, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

credits For the starter credits tickets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants