Skip to content

#3712-End-Date-Change-Display-in-CR-Review#3749

Merged
walker-sean merged 8 commits intodevelopfrom
#3712-maintenence---end-date-change-display-in-cr-review
Nov 14, 2025
Merged

#3712-End-Date-Change-Display-in-CR-Review#3749
walker-sean merged 8 commits intodevelopfrom
#3712-maintenence---end-date-change-display-in-cr-review

Conversation

@rbessin
Copy link
Copy Markdown
Contributor

@rbessin rbessin commented Nov 11, 2025

Changes

  • Calculated proposedChangesEndDate using the proposedChanges startDate and duration and use an empty string if proposedChanges is undefined.
  • Added an additional endDate section to the proposedChanges area.
  • Displays the original end date and the newly proposed one.

Screenshots

image image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #3712 )

@rbessin
#3712 added end date label to proposed changes by fetching original e…
b9063c3 
…ndDate and calculating proposedEndDate using startDate and duration
@rbessin rbessin self-assigned this Nov 11, 2025
superhvarn
superhvarn requested changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@superhvarn superhvarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the prettier check!

@rbessin
Copy link
Copy Markdown
Contributor Author

rbessin commented Nov 11, 2025

LGTM, just fix the prettier check!
Just did!

superhvarn
superhvarn requested changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@superhvarn superhvarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to use datePipe instead of toLocaleString()

@rbessin
Copy link
Copy Markdown
Contributor Author

rbessin commented Nov 11, 2025

I made the changes to use datePipe but that means the endDate doesn't include the time.

@superhvarn superhvarn force-pushed the #3712-maintenence---end-date-change-display-in-cr-review branch from 8192fab to d3a4c8c Compare November 11, 2025 23:44
@superhvarn superhvarn self-requested a review November 11, 2025 23:45
superhvarn
superhvarn previously approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@superhvarn superhvarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@superhvarn superhvarn self-requested a review November 11, 2025 23:50
superhvarn
superhvarn previously approved these changes Nov 11, 2025
View reviewed changes
@rbessin rbessin force-pushed the #3712-maintenence---end-date-change-display-in-cr-review branch from 0188b20 to 982ce06 Compare November 13, 2025 00:09
@rbessin
Merge branch '#3712-maintenence---end-date-change-display-in-cr-revie…
c48f310 
…w' of github.com:Northeastern-Electric-Racing/FinishLine into #3712-maintenence---end-date-change-display-in-cr-review
@superhvarn superhvarn self-requested a review November 13, 2025 00:15
superhvarn
superhvarn previously approved these changes Nov 13, 2025
View reviewed changes
walker-sean
walker-sean approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@walker-sean walker-sean merged commit feb9f84 into develop Nov 14, 2025
4 checks passed
@walker-sean walker-sean deleted the #3712-maintenence---end-date-change-display-in-cr-review branch November 14, 2025 01:18
saulmanz added a commit that referenced this pull request Nov 24, 2025
@saulmanz
Squashed commit of the following:
2eaeb54 
commit 5f45f9f
Merge: 04cc5bc 895852f
Author: Waverly Hassman <147569744+wavehassman@users.noreply.github.com>
Date:   Sat Nov 22 00:21:26 2025 -0500

    Merge pull request #3765 from Northeastern-Electric-Racing/#3635-create-and-edit-calendar-modal

    #3635 create and edit calendar modal

commit 895852f
Author: wavehassman <wavehassman@gmail.com>
Date:   Sat Nov 22 00:16:50 2025 -0500

    #3635 requested changes

commit 422dda3
Author: wavehassman <wavehassman@gmail.com>
Date:   Fri Nov 21 13:28:10 2025 -0500

    #3635 requested changed and more

commit b5063c3
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Thu Nov 20 11:42:25 2025 -0500

    #3635 prettier fix

commit cb8d304
Merge: c6d72b7 04cc5bc
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Thu Nov 20 11:23:36 2025 -0500

    Merge branch 'feature/calendar-improvements' into #3635-create-and-edit-calendar-modal

commit c6d72b7
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Thu Nov 20 11:16:43 2025 -0500

    #3635 review changes

commit 04cc5bc
Merge: 3f93d26 3f455b6
Author: wavehassman <wavehassman@gmail.com>
Date:   Wed Nov 19 19:02:25 2025 -0500

    Merge branch 'develop' into feature/calendar-improvements

commit b35a3f4
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Mon Nov 17 09:52:27 2025 -0500

    #3635 prettier fix

commit 6867957
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Mon Nov 17 09:50:05 2025 -0500

    #3635 additional merge fix

commit 320b8b0
Merge: 8a0c3cd 43a5ee9
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Mon Nov 17 09:49:09 2025 -0500

    Merge branch 'feature/calendar-improvements' into #3635-create-and-edit-calendar-modal

commit 3f455b6
Merge: a048d4a 7e01601
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Sun Nov 16 17:52:57 2025 -0500

    Merge pull request #3657 from Northeastern-Electric-Racing/#3209-SABO-number-limit

    #3209 sabo number limit

commit a048d4a
Merge: 46764d6 ffa1107
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Sun Nov 16 17:03:01 2025 -0500

    Merge pull request #3532 from Northeastern-Electric-Racing/#3494-wp-status-in-cr-diff

    #3494 wp status in cr bug

commit ffa1107
Author: Chris Pyle <pyle.c@northeastern.edu>
Date:   Sun Nov 16 16:58:04 2025 -0500

    #3494 only copy status if editting existing element not when creating new element

commit 562b616
Merge: a3c7f0f 46764d6
Author: Chris Pyle <pyle.c@northeastern.edu>
Date:   Sun Nov 16 15:36:58 2025 -0500

    Merge branch 'develop' into #3494-wp-status-in-cr-diff

commit 8a0c3cd
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Sat Nov 15 20:56:49 2025 -0500

    #3635 Slight fixes

commit 0e36a5a
Merge: 1f49e88 b190db4
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Sat Nov 15 20:10:01 2025 -0500

    Merge branch 'feature/calendar-improvements' into #3635-create-and-edit-calendar-modal

commit 1f49e88
Author: sayegh.st@northeastern.edu <stephaniesayegh375@gmail.com>
Date:   Sat Nov 15 20:08:32 2025 -0500

    #3635 initial calendar modal

commit 46764d6
Merge: c28f83d 6fb9587
Author: Sean Walker <114596410+walker-sean@users.noreply.github.com>
Date:   Sat Nov 15 18:16:28 2025 -0500

    Merge pull request #3751 from Northeastern-Electric-Racing/3133-availability---make-editconfirm-availability-modals-larger

    #3133 make edit/confirm availability modals larger

commit c28f83d
Merge: a8e16bb 050ffeb
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:32:48 2025 -0500

    Merge pull request #3756 from Northeastern-Electric-Racing/#3727-EdgarButtner-Credits

    #3727 Added my name to credits

commit a8e16bb
Merge: 5f57a68 446efb3
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:31:46 2025 -0500

    Merge pull request #3753 from Northeastern-Electric-Racing/#3752-task-creator-can-delete-own-tasks

    #3752: task creators can now delete their own tasks regardless of role

commit 5f57a68
Merge: 85f9531 06cbeda
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:29:36 2025 -0500

    Merge pull request #3716 from Northeastern-Electric-Racing/tonys-branch

    Tony Feng - Credits

commit 06cbeda
Merge: 30f9d4d 85f9531
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:23:03 2025 -0500

    Merge branch 'develop' into tonys-branch

commit 85f9531
Merge: 48efad2 0c9ccb7
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:21:24 2025 -0500

    Merge pull request #3732 from Northeastern-Electric-Racing/3731-maintenence---link-types-cannot-be-edited

    #3731 link type edit works

commit 48efad2
Merge: feb9f84 06ed70e
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Fri Nov 14 09:17:20 2025 -0500

    Merge pull request #3713 from Northeastern-Electric-Racing/#3709-AnthonyBasko-credits

    #3709: Added my name and color/fx to the credits page

commit 6fb9587
Author: Tony Feng <tonywf15@gmail.com>
Date:   Thu Nov 13 20:45:02 2025 -0500

    #3133 adjusted fontsizes and rebolded days of week timeslots

commit 181689e
Author: Tony Feng <tonywf15@gmail.com>
Date:   Thu Nov 13 20:31:44 2025 -0500

    #3133 adjusted timeslot heights

commit c0e652d
Author: Tony Feng <tonywf15@gmail.com>
Date:   Thu Nov 13 20:20:14 2025 -0500

    #3133 fixed height and width override props

commit feb9f84
Merge: 9602027 871d066
Author: Sean Walker <114596410+walker-sean@users.noreply.github.com>
Date:   Thu Nov 13 20:18:41 2025 -0500

    Merge pull request #3749 from Northeastern-Electric-Racing/#3712-maintenence---end-date-change-display-in-cr-review

    #3712-End-Date-Change-Display-in-CR-Review

commit 9602027
Merge: ba2254a d5dfd95
Author: Sean Walker <114596410+walker-sean@users.noreply.github.com>
Date:   Thu Nov 13 20:12:09 2025 -0500

    Merge pull request #3736 from Northeastern-Electric-Racing/prospective-sponsors

    Company Table Redesigns

commit da977c1
Merge: 56cd095 b04f48b
Author: Tony Feng <tonywf15@gmail.com>
Date:   Thu Nov 13 00:31:05 2025 -0500

    Merge branch '3133-availability---make-editconfirm-availability-modals-larger' of https://github.com/Northeastern-Electric-Racing/FinishLine into 3133-availability---make-editconfirm-availability-modals-larger

commit 871d066
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Wed Nov 12 20:19:52 2025 -0500

    push changes using datePipe

commit 56cd095
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 19:26:34 2025 -0500

    #3133 changed width and height override props to be optional, made days of the week typography elements

commit d2fa546
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Wed Nov 12 19:33:15 2025 -0500

    use datePipe instead of .getTime()

commit b04f48b
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 19:26:34 2025 -0500

    changed width/height override to optional props, made days of the week typography elements

commit 050ffeb
Merge: 92ad1e8 ba2254a
Author: Edgar Buttner <buttner.e@northeastern.edu>
Date:   Wed Nov 12 19:17:31 2025 -0500

    Merge branch 'develop' into #3727-EdgarButtner-Credits

commit c48f310
Merge: 982ce06 0188b20
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Wed Nov 12 19:10:19 2025 -0500

    Merge branch '#3712-maintenence---end-date-change-display-in-cr-review' of github.com:Northeastern-Electric-Racing/FinishLine into #3712-maintenence---end-date-change-display-in-cr-review

commit 982ce06
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Wed Nov 12 19:05:35 2025 -0500

    updated start date to use datePipe

commit 0c9ccb7
Author: harish <harivarada1@gmail.com>
Date:   Wed Nov 12 17:56:20 2025 -0500

    #3731 minor fixes

commit 05fb584
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 17:21:13 2025 -0500

    #3133 fixed deleted 40px height override and 13px font

commit 92ad1e8
Author: Edgar Buttner <buttneredgar@gmail.com>
Date:   Wed Nov 12 14:16:04 2025 -0500

    #3727 Added my name to credits

commit 8c1beee
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 02:18:44 2025 -0500

    #3133 fixed prettier formatting

commit 70c7ca7
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 02:14:14 2025 -0500

    #3133 fixed timeslot alignment in edit availability modal and changed text type to React.ReactNode in timeslot interface

commit 38de683
Author: Tony Feng <tonywf15@gmail.com>
Date:   Wed Nov 12 00:54:14 2025 -0500

    #3133 made edit availability modal larger as well as timeslots larger

commit 446efb3
Author: Griffin Cooper <72273901+gcooper407@users.noreply.github.com>
Date:   Tue Nov 11 19:54:52 2025 -0500

    #3752: task creators can now delete their own tasks regardless of role

commit 91c0aa1
Author: Tony Feng <tonywf15@gmail.com>
Date:   Tue Nov 11 19:11:22 2025 -0500

    #3133 fixed prettier formatting

commit 0188b20
Author: harish <harivarada1@gmail.com>
Date:   Tue Nov 11 18:49:31 2025 -0500

    adding raphael's commit back

commit 8192fab
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Tue Nov 11 18:22:52 2025 -0500

    #3712 updated to use datePipe

commit a509a47
Author: Tony Feng <tonywf15@gmail.com>
Date:   Tue Nov 11 18:18:57 2025 -0500

    #3133 made availability edit modal larger

commit d3a4c8c
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Tue Nov 11 16:49:12 2025 -0500

    #3712 updated prettier formatting

commit b9063c3
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Tue Nov 11 16:24:08 2025 -0500

    #3712 added end date label to proposed changes by fetching original endDate and calculating proposedEndDate using startDate and duration

commit d5dfd95
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Tue Nov 11 16:16:04 2025 -0500

    requested changes

commit ba2254a
Merge: 32f0202 f3caadc
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Mon Nov 10 23:23:13 2025 -0500

    Merge pull request #3714 from Northeastern-Electric-Racing/3688-john-cassidy---credits

    #3688: Add my name to credits

commit f3caadc
Merge: f4b4fe3 32f0202
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Mon Nov 10 23:19:11 2025 -0500

    Merge branch 'develop' into 3688-john-cassidy---credits

commit 32f0202
Merge: db62ca6 13f0e0f
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Mon Nov 10 23:17:33 2025 -0500

    Merge pull request #3722 from Northeastern-Electric-Racing/3687-raphael-bessin---credits

    Update CreditsPage.tsx

commit db62ca6
Merge: a61544c 7e67a13
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Mon Nov 10 23:17:02 2025 -0500

    Merge pull request #3743 from Northeastern-Electric-Racing/#3864-SathvikCharugundla-credits

    #3864 sathvik charugundla credits

commit a61544c
Merge: 99a3c70 c2130a0
Author: Chris Pyle <118906070+chpy04@users.noreply.github.com>
Date:   Mon Nov 10 23:13:21 2025 -0500

    Merge pull request #3690 from Northeastern-Electric-Racing/#3686-GahanPatel-credits

    #3686 Added my name to credits

commit 7e67a13
Merge: 950f247 99a3c70
Author: patriots1 <charugundla.s@northeastern.edu>
Date:   Mon Nov 10 13:08:31 2025 -0500

    Merge branch 'develop' into #3864-SathvikCharugundla-credits

commit 727a50e
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sun Nov 9 18:41:30 2025 -0500

    removed extra options from sponsors table

commit c2130a0
Merge: 3648f04 99a3c70
Author: Gahan Patel <patel.gah@northeastern.edu>
Date:   Sun Nov 9 17:54:33 2025 -0500

    3686-GahanPatel-added credtits

commit 8eeae6b
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 22:02:11 2025 -0500

    testing is for people not confident in their code

commit 29c0e39
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 21:52:32 2025 -0500

    tests

commit 5ff873f
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 21:38:41 2025 -0500

    removed annoying comments

commit a2461bc
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 18:15:01 2025 -0500

    removed log

commit 86f52de
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 18:07:57 2025 -0500

    tables done

commit c4b03e1
Author: Sean Walker <walker.se@northeastern.edu>
Date:   Sat Nov 8 15:42:55 2025 -0500

    most of table redesign

commit 3648f04
Author: Gahan Patel <patel.gah@northeastern.edu>
Date:   Fri Nov 7 12:35:41 2025 -0500

    update

commit 6c408cb
Author: harish <harivarada1@gmail.com>
Date:   Thu Nov 6 17:35:01 2025 -0500

    #3731 linting

commit 268fbdb
Author: harish <harivarada1@gmail.com>
Date:   Thu Nov 6 17:31:40 2025 -0500

    #3731 removing use effect

commit 0d54778
Author: harish <harivarada1@gmail.com>
Date:   Thu Nov 6 17:26:02 2025 -0500

    #3731 link type edit works

commit 06ed70e
Author: Anthony Basko <75228079+nunnyu@users.noreply.github.com>
Date:   Wed Nov 5 19:07:08 2025 -0500

    Prettier linting fix

commit dde5640
Merge: 54fe9ae eb74e08
Author: Anthony Basko <75228079+nunnyu@users.noreply.github.com>
Date:   Wed Nov 5 00:51:16 2025 -0500

    Merge branch 'develop' into #3709-AnthonyBasko-credits

commit 30f9d4d
Author: Tony Feng <tonywf15@gmail.com>
Date:   Tue Nov 4 16:53:20 2025 -0500

    added credits

commit f4b4fe3
Author: John Cassidy <jjcassidy18@icloud.com>
Date:   Tue Nov 4 12:24:06 2025 -0500

    #3688: prettier formating

commit 54fe9ae
Author: Anthony Basko <75228079+nunnyu@users.noreply.github.com>
Date:   Mon Nov 3 20:35:47 2025 -0500

    #3709: Added my name and color/fx to the credits page

    in frontend\src\pages\CreditsPage\CreditsPage.tsx

commit 950f247
Merge: c7c1443 e61d4e6
Author: patriots1 <charugundla.s@northeastern.edu>
Date:   Mon Nov 3 08:30:37 2025 -0500

    Merge branch 'develop' into #3864-SathvikCharugundla-credits

commit 9d395a6
Author: Gahan Patel <patel.gah@northeastern.edu>
Date:   Wed Oct 29 21:09:57 2025 -0400

    #3686 Added my name to credits

commit c7c1443
Author: patriots1 <charugundla.s@northeastern.edu>
Date:   Wed Oct 29 20:56:24 2025 -0400

    #3864 changed color of my name in credits page

commit 08e9bc1
Author: John Cassidy <jjcassidy18@icloud.com>
Date:   Wed Oct 29 20:13:15 2025 -0400

    Add my name to credits

commit 13f0e0f
Author: Raphael Bessin <bessin.raphael@gmail.com>
Date:   Wed Oct 29 19:51:06 2025 -0400

    Update CreditsPage.tsx

commit 7e01601
Author: jasonk55 <jasonkuo55@gmail.com>
Date:   Wed Oct 15 01:59:59 2025 -0400

    #3209 SABO number limited to exactly 5 digits

commit 956c4e3
Author: jasonk55 <jasonkuo55@gmail.com>
Date:   Tue Oct 14 15:49:46 2025 -0400

    #3209 SABO number has to be at least 5 digits

commit 41bbc6a
Author: jasonk55 <jasonkuo55@gmail.com>
Date:   Tue Oct 14 15:16:56 2025 -0400

    #3209 leading zeros allowed in SABO ID

commit a3c7f0f
Author: Sarah Taylor <150694563+staysgt@users.noreply.github.com>
Date:   Tue Sep 16 21:21:45 2025 -0400

    #3494 updated tests

commit 57b373c
Author: Sarah Taylor <150694563+staysgt@users.noreply.github.com>
Date:   Tue Sep 16 20:49:18 2025 -0400

    #3494 lint

commit da17421
Author: Sarah Taylor <150694563+staysgt@users.noreply.github.com>
Date:   Tue Sep 16 20:46:17 2025 -0400

    #3494 fixes in both places + tests

commit 4ac11d0
Author: Sarah Taylor <150694563+staysgt@users.noreply.github.com>
Date:   Sat Aug 23 11:15:36 2025 -0400

    #3494 defaults to original status and not active

commit 0f71588
Author: Sarah Taylor <150694563+staysgt@users.noreply.github.com>
Date:   Sun Aug 17 22:40:21 2025 -0400

    #3494 bug wp status in cr
Merge branch 'feature/calendar-improvements' into 3775-Delete-Calendar-Modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walker-sean walker-sean walker-sean approved these changes

@superhvarn superhvarn superhvarn left review comments

@gcooper407 gcooper407 Awaiting requested review from gcooper407

Assignees

@rbessin rbessin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbessin @superhvarn @walker-sean