Skip to content

#3802 if cr has requested reviewers, only they can approve#3829

Merged
walker-sean merged 3 commits intodevelopfrom
#3802-specific-reviewers-on-crs
Dec 13, 2025
Merged

#3802 if cr has requested reviewers, only they can approve#3829
walker-sean merged 3 commits intodevelopfrom
#3802-specific-reviewers-on-crs

Conversation

@chpy04
Copy link
Copy Markdown
Contributor

@chpy04 chpy04 commented Dec 13, 2025

Changes

If a CR has no requested reviewers, the functionality remains the same. If it has requested reviewers, only they can approve the CR

Notes

also added tool tip to the actions menu to tell users why they can't approve

Screenshots

Screenshot 2025-12-12 at 9 13 31 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3802

@chpy04 chpy04 requested a review from walker-sean December 13, 2025 02:14
@walker-sean walker-sean merged commit ca6acc3 into develop Dec 13, 2025
4 checks passed
@walker-sean walker-sean deleted the #3802-specific-reviewers-on-crs branch December 13, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Change Request] - Specific reviewers other than just same team

2 participants