-
Notifications
You must be signed in to change notification settings - Fork 9
#3896 added term_definition and sponsor logoImageId to schema #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chpy04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chpy04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to talk about how this will actually work in the frontend. This aligns with the admin tools, but Im not sure it aligns with what the frontend actually looks like in the epic
chpy04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need description field on projects for same thing as divisions
Changes
Added a term_definition model and added a logoImageId field to the sponsor model in the schema.
Notes
The term_definition is to hold the terms and definitions on the admin tools page. The logoImageId is to hold the image for the guest sponsors page.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3896