Skip to content

#3901 added add rule section modal #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aryan0102 merged 3 commits into from
Jan 20, 2026
Merged

#3901 added add rule section modal #3904

Aryan0102 merged 3 commits into from
Jan 20, 2026

Conversation

@Zwendle
Copy link
Contributor

@Zwendle Zwendle commented Jan 20, 2026

Changes

Added add rule section modal (only adds rules to the top-most level of the rule hierarchy)

Notes

  • ruleContent is currently a required field in hooks + backend, so for this modal it defaults to "content placeholder".

Screenshots

Screenshot 2026-01-19 at 22 26 15 Screenshot 2026-01-19 at 22 26 39 Screenshot 2026-01-19 at 22 26 48

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3901

@Zwendle Zwendle self-assigned this Jan 20, 2026
@Zwendle Zwendle requested a review from Aryan0102 January 20, 2026 03:28
Aryan0102
Aryan0102 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@Aryan0102 Aryan0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aryan0102 Aryan0102 merged commit 82dcd31 into feature/rules-dashboard Jan 20, 2026
4 checks passed
@Aryan0102 Aryan0102 deleted the #3901-add-rule-section-modal branch January 20, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aryan0102 Aryan0102 Aryan0102 approved these changes

Assignees

@Zwendle Zwendle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zwendle @Aryan0102