Merged
Conversation
include optional car param for getAllWorkPackages and getManyWorkPackages
enable support of optional car param with getAllWorkPackages and getManyWorkPackages
add optional car param to more methods
make sure optional car param is used
include checks for optional car param
…llProjects-endpoints-car-filtering #3950 get projects endpoints car filtering
Add backend support for global car filtering
…Packages-Endpoints
update controller for middleware, fix bug due to type change in service
…ar, project, wp order and add carId filtering tests
…tion + fix carNumber truthiness bug
…ement request list endpoints
chpy04
requested changes
Apr 6, 2026
Contributor
chpy04
left a comment
There was a problem hiding this comment.
Really good work, main thing is dedicated all cars handling instead of implicit with undefined. Also in terms of UI, on the selector:
Can we
- add some spacing on to of the "Working with" so its not so close to the top of the screen
- Make the car options go all the way to the right below the sidebar arrow instead of getting horizontally cut off even when there is nothing to the right of them
… through query object and fix prettier issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pages updated for filtering included: Home, Gantt, Projects, Change Requests, Finance.
Pages excluded from global filtering: Teams, Statistics, Calendar, Restrospective.
Notes
Two features follow slightly different formats than the rest of the website for unique reasons.
Side changes that I believe were important to note.
Compared to the ticket, some implementations are slightly different.
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3629