#3945 don't send slack notif when user is assignee

[getheobald]

Changes

Added a check for user id when sending a slack task assignment notification such that no notification is sent when assigning tasks to oneself

Notes

• There are 2 backend tests failing but they're not related so I think that's not my circus not my monkeys?
• There is a typo in the params on this function but I didn't change it since I assume it's not in the scope of this ticket. But if it is I will happily fix the typo!!!

Test Cases

• Manually tested assigning myself a task, and no notif was sent as expected
• Manually tested assigning another user a task and notif was sent as expected
• Manually tested reassigning a task from myself to another user and notif was sent as expected
• Manually tested reassigning a task from another user to myself and no notif was sent as expected

Screenshots

Not sure if I need to include screenshots for manual e2e tests but here's the slack dm output

Checklist

• All commits are tagged with the ticket number
• No linting errors / newline at end of file warnings
• All code follows repository-configured prettier formatting
• No merge conflicts
• All checks passing
• Screenshots of UI changes (see Screenshots section)
• Remove any non-applicable sections of this template
• Assign the PR to yourself
• No yarn.lock changes (unless dependencies have changed)
• Request reviewers & ping on Slack
• PR is linked to the ticket (fill in the closes line below)

Closes #3945

[chpy04]

This is kind of nit picky, but I'd rather this check be in the service function than in the slack utils function. The slack utils functions should be responsible for formatting the slack message and wrapping the api calls, but it should be the service function's resposibility to determine whether or not the slack message should be sent.

[getheobald]

No probs! Made the change and retested

[chpy04]

lit