ALV-74: Fork mender-connect and add support for HTTP standalone mode #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alfrunes merged 26 commits into NorthernTechHQ:main from alfrunes:ALV-74

Sep 1, 2023

Contributor

alfrunes commented Aug 28, 2023 •

edited

Loading

This PR introduces a number of new features:

Operate in standalone mode (API.Type = "http")
- Behavior is defined in the API.* section of the config
- A bootstrap command is added to generate the identity
- The http (and dbus-) client uses exponential random backoff for retries.
New entrypoint that integrates with IoT Edge environment
- The new entrypoint bootstraps the device and submits the identity to IoT Edge's module twin for automatic Authorization with Alvaldi.

The core Daemon app has been refactored to eliminate redundant event loops and centralize the use of channels.

TODO(follow-up): Run and publish inventory scripts
TODO(follow-up): Write unit tests for the new utility and api packages.
TODO(follow-up): Use buildtags for opt-in dynamic dependencies (libdbus, libglib)

alfrunes added 23 commits

August 22, 2023 16:05


          feat(poc): nt-connect with azure integration for authorizing devices

d83b760

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          feat: Add bootstrap command for generating local authentication par…

177d5cf

…ameters

Changelog: Title

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          refac: Rename config.Auth* to config.API*

3c454c2

The naming is more appropriate since we will also include inventory
script and possibly http/tls options in the configuration scope.

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore(mod): Rename module to github.com/northerntechhq/nt-connect

aa81428

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          refac: Rename application and default paths to nt-connect

5294d66

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          feat: bootstrap command dumps the identity to stdout on exit

5e441f3

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          refac: Move client/* packages to api/* and remove dbus from interface

ffef1a1

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          refac: Use channel based socket interface and remove global connectio…

4e9632c

…nmanager

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          fix: Initialize required directories in Dockerfile

d1745df

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore: Adjust entrypoint to use bootstrap command

a818ec7

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore: Remove TENANT_TOKEN from example

2598fce

This blocks it from being picked up from the env variable

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore: Begone python-cryptography

dd3bfff

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore(ci): Linting fixes

c9674c2

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          fix(api/ws): Protect websocket from concurrent writes

fc18155

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          feat(api): Add exponential backoff to the client interface

81d703a

Changelog: Title
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore(fix): Restore the dbus authorization handling logic

46ddaf5

TODO: Should the client reconnect on JwtTokenStateChange dbus signal?

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore(rename): Rename config and service file

880802e

new file:   support/nt-connect.json
renamed:    examples/{mender -> nt}-connect.conf
renamed:    support/{mender -> nt}-connect.service

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          test(shell): Fix unit tests after refactoring

0a3aa4d

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          refac: Move api.Client to Daemon object

6771add

Makes it easier to use mocks while testing.

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore: Improve api errors and handle retryable error codes

a41c986

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          test(app): Fix broken unit tests after refactoring

da3720c

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          chore(dbus): Quit main loop on termination

399612c

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          test(config): Fix unit tests after adding default path values

4daacb8

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

alfrunes requested a review from kjaskiewiczz

August 28, 2023 15:52

alfrunes added 3 commits

August 28, 2023 18:23


          feat(config): Environment override for API.{TenantToken|ServerURL} an…

bcf9dd1

…d Chroot

The environment variables CONNECT_TENANT_TOKEN, CONNECT_SERVER_URL and
CONNECT_CHROOT overrides the configuration values for API.TenantToken,
API.ServerURL and Chroot respectively if set.

Changelog: Commit
Ticket: None
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          test(session): Fix broken unit tests after refactoring

1ae7bc1

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>


          ci: Update license headers

d56b740

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

kjaskiewiczz approved these changes

View reviewed changes

Contributor

kjaskiewiczz left a comment

LGTM, but at the same time I don't feel like I'm the right person to review it;

alfrunes merged commit fd202f8 into NorthernTechHQ:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet