Dependency upgrades #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alfrunes
commented
Nov 14, 2023
alfrunes
commented
- github.com/gorilla/websocket v1.5.0 -> v1.5.1
- github.com/mendersoftware/go-lib-micro v0.0.0-20230808081028-48c0b853fd99 -> v0.0.0-20231031082957-e2bce6ff3edd
- github.com/urfave/cli/v2 v2.0.0-00010101000000-000000000000 -> v2.25.7
alfrunes
force-pushed
the
deps-upgrade
branch
from
e758f06 to
c3a1834
Compare
Contributor
|
I think we are lacking some checks in this repository - gitlab pipeline failed, nobody approved and I can still merge the PR. |
Contributor
|
@kjaskiewiczz Thanks, I've added some basic branch protection. |
kjaskiewiczz
approved these changes
Nov 14, 2023
Contributor
kjaskiewiczz
left a comment
kjaskiewiczz
left a comment
There was a problem hiding this comment.
looks good, but the license checker is not happy
olehermanse
requested changes
Nov 14, 2023
Contributor
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
LGTM, except for CI.
alfrunes
force-pushed
the
deps-upgrade
branch
from
c3a1834 to
9112bcd
Compare
Contributor
Author
|
I dropped the commit removing the |
* github.com/gorilla/websocket v1.5.0 -> v1.5.1 * github.com/mendersoftware/go-lib-micro v0.0.0-20230808081028-48c0b853fd99 -> v0.0.0-20231031082957-e2bce6ff3edd * github.com/urfave/cli/v2 v2.0.0-00010101000000-000000000000 -> v2.25.7 Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
alfrunes
force-pushed
the
deps-upgrade
branch
from
9112bcd to
ac422e9
Compare
olehermanse
changed the title
olehermanse
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.