-
Notifications
You must be signed in to change notification settings - Fork 6
ALV-223: CI for building tarball packages #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
The default prefix paths are set to the Makefile defaults. If DESTDIR is set, change the defaults to comply with Debian packaging. Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
bfad95a to
dd41123
Compare
87e347a to
a91a086
Compare
|
I changed the PR to only create tarballs that can be installed by |
A tarball is as generic as it gets :) The only think to take care of is the configuration file. This is likely for a user to modify and then it would be unexpected that upgrading to a new tarball will replace the file. This we can take care in the install script somehow. I honestly think that it is the best for now given the requirements. We can always migrate to Debian or rpm packages later if we want something more streamlined. |
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Makefile
Outdated
| dist: DESTDIR=dist/nt-connect_$(VERSION)_$(GOOS)_$(GOARCH) | ||
| dist: | ||
| @make DESTDIR=$(DESTDIR) -B install | ||
| tar -C $(DESTDIR) -czf $(DESTDIR).tar.gz . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, right! I'll instead install into a temporary directory and only create the tarballs in dist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made it really simple by adding --remove-files to the tar command so it removes them as they are added to the archive.
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

Fixed up the Makefile and added a simple script to build Debian package for
amd64,arm64andarmhf.