fix: Stop shell after health check fails #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mender-connect` has two levels of ping/pong, the standard websockets
one and a custom `shell` protocol one. On the later, when the peer does
not respond to the ping request the shell session, the session is marked
as expired but there was no default mechanism to stop the shell and get
ready for new shells.
The symptom of this bug is that after temporally lose of connectivity,
`mender-connect` will still refuse to open new shells after the
connectivity is restored.
It was possible to configure `mender-connect` to stop shells from expired
sessions. See changelog entry below.
Ticket: MEN-6888
Changelog: Stop shell after the ping/pong health check fails, so that
the `mender-connect` can recover after disruption of connectivity.
For already released versions of `mender-connect` the workaround is to
force the stop of shells for expired sessions adding to the
configuration options the fields:
```
"Sessions": {
"StopExpired": true,
"ExpireAfterIdle": 600
}
```
Setting a limit for expiration high enough (10 minutes, above) so that it
doesn't interfere with regular operations.
See https://docs.mender.io/add-ons/mender-connect#remote-terminal-configuration
Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
(cherry picked from commit mendersoftware/mender-connect@e337160)
lluiscampos
approved these changes
Jan 30, 2024
Contributor
lluiscampos
left a comment
lluiscampos
left a comment
There was a problem hiding this comment.
It looks good to me (obliviously 😅 ) but I recommend to wait for merging until mendersoftware/mender-connect#130 is done in case there is feedback there that is applicable for nt-connect as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mender-connecthas two levels of ping/pong, the standard websockets one and a customshellprotocol one. On the later, when the peer does not respond to the ping request the shell session, the session is marked as expired but there was no default mechanism to stop the shell and get ready for new shells.The symptom of this bug is that after temporally lose of connectivity,
mender-connectwill still refuse to open new shells after the connectivity is restored.It was possible to configure
mender-connectto stop shells from expired sessions. See changelog entry below.Ticket: MEN-6888
Changelog: Stop shell after the ping/pong health check fails, so that the
mender-connectcan recover after disruption of connectivity. For already released versions ofmender-connectthe workaround is to force the stop of shells for expired sessions adding to the configuration options the fields:Setting a limit for expiration high enough (10 minutes, above) so that it doesn't interfere with regular operations.
See https://docs.mender.io/add-ons/mender-connect#remote-terminal-configuration
(cherry picked from commit mendersoftware/mender-connect@e337160)