Skip to content

chore: support local NuGet source via NOSCORE_LOCAL_PACKAGES env var#113

Merged
erwan-joly merged 1 commit intomasterfrom
revert-nuget-local-source
Apr 24, 2026
Merged

chore: support local NuGet source via NOSCORE_LOCAL_PACKAGES env var#113
erwan-joly merged 1 commit intomasterfrom
revert-nuget-local-source

Conversation

@erwan-joly
Copy link
Copy Markdown
Contributor

@erwan-joly erwan-joly commented Apr 24, 2026

Summary

  • Adds Directory.Build.props with a conditional RestoreAdditionalProjectSources that activates only when NOSCORE_LOCAL_PACKAGES is set.
  • No runtime cost for contributors who don't opt in — the property group is skipped, restore uses nuget.org only.
  • To use: setx NOSCORE_LOCAL_PACKAGES C:\LocalPackages, restart shell/VS, drop .nupkg files into the folder. Replaces the earlier NuGet.config-based attempt, which broke restore (NU1301) whenever the env var was unset.

Test plan

  • dotnet restore succeeds with NOSCORE_LOCAL_PACKAGES unset.
  • dotnet restore with NOSCORE_LOCAL_PACKAGES pointing to a folder with a .nupkg picks it up.

Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@erwan-joly has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 35 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 35 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eec80aa-4725-4c56-8f30-b207c9df4fce

📥 Commits

Reviewing files that changed from the base of the PR and between 4da4b68 and 7e8e654.

📒 Files selected for processing (2)
  • Directory.Build.props
  • NuGet.config
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-nuget-local-source

Comment @coderabbitai help to get the list of available commands and usage tips.

Move the wiring out of NuGet.config (where %NOSCORE_LOCAL_PACKAGES%
fails NU1301 when unset) into a conditional Directory.Build.props
PropertyGroup. RestoreAdditionalProjectSources is only set when the
env var is defined, so CI and fresh clones are unaffected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@erwan-joly erwan-joly force-pushed the revert-nuget-local-source branch from 2d14149 to 7e8e654 Compare April 24, 2026 03:20
@erwan-joly erwan-joly changed the title Revert: local NuGet source via NOSCORE_LOCAL_PACKAGES breaks restore when env var is unset chore: support local NuGet source via NOSCORE_LOCAL_PACKAGES env var Apr 24, 2026
@erwan-joly erwan-joly merged commit 591f783 into master Apr 24, 2026
2 checks passed
@erwan-joly erwan-joly deleted the revert-nuget-local-source branch April 24, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant