perf: batch packet-log UI; rename Send/Recv tags to Client/Server

[erwan-joly]

Summary

• Perf — batched log drain. Captured packets used to hit the UI thread via one BeginInvoke + one ListBox.Items.Add + one TopIndex update per packet. At high packet rates that saturated the message loop — the log got visibly laggy and Select All could stall the UI for seconds. Now the capture path just enqueues onto a ConcurrentQueue, and a 50 ms UI-thread Timer drains the queue into a single BeginUpdate / AddRange / EndUpdate block.
• Perf — Select All. 5000-item SetSelected loop used to repaint per call. Wrapped in BeginUpdate / EndUpdate.
• Perf — display string caching. LoggedPacket.ToString() is called on every repaint per visible row. Formatted string is now computed once in the record's field initializer.
• UX — rename tags. [Send] / [Recv] were ambiguous (send by whom?). Replaced with [Client] (originated on the game client, i.e. client→server) and [Server] (originated on the server, i.e. server→client).

Test plan

• Attach to a live client, confirm packet log keeps up during a zone change or mass-mob spawn without the UI locking.
• Select All on a full 5000-row log — should be instant.
• Copy (Ctrl+C) and Copy with tags still work; tags now read [World] [Client] / [World] [Server].
• Clear button drains both the queue and the listbox.

Summary by CodeRabbit

Release Notes

• New Features

  • Added packet validation with a dedicated Issues tab displaying validation results
  • Enhanced log visualization with color-coded packet categories

• Improvements

  • Optimized UI performance with batch updates
  • Unified copy and selection functionality across all views

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 837eb1c0-5ea6-4e10-a730-1a9be02281c8

📥 Commits

Reviewing files that changed from the base of the PR and between 35d7e26 and f38e058.

📒 Files selected for processing (5)

• src/NosCore.DeveloperTools/Forms/MainForm.cs
• src/NosCore.DeveloperTools/Models/LoggedPacket.cs
• src/NosCore.DeveloperTools/Models/PacketValidationIssue.cs
• src/NosCore.DeveloperTools/Program.cs
• src/NosCore.DeveloperTools/Services/PacketValidationService.cs

---

📝 Walkthrough

Walkthrough

This PR introduces packet validation functionality to the developer tools. A new PacketValidationService validates captured packets through reflection-based type analysis and deserialization attempts. The MainForm displays validation issues in a dedicated UI tab, processes packets via a thread-safe queue with timer-based updates, applies owner-drawn rendering, and unifies context menus across both log and issues listboxes.

Changes

Cohort / File(s)	Summary
Packet Models src/NosCore.DeveloperTools/Models/LoggedPacket.cs, src/NosCore.DeveloperTools/Models/PacketValidationIssue.cs	Added Issue property to LoggedPacket; changed display format from Send/Recv to Client/Server; cached string representation. New ValidationCategory enum and PacketValidationIssue record with precomputed formatted display and direction/connection mappings.
Validation Service src/NosCore.DeveloperTools/Services/PacketValidationService.cs	New service that reflects over PacketBase subclasses to build direction-specific header type collections and instantiates dual Deserializer objects for client/server validation. Returns PacketValidationIssue with Missing, WrongStructure, or WrongTag categories based on deserialization outcomes.
UI & Integration src/NosCore.DeveloperTools/Forms/MainForm.cs, src/NosCore.DeveloperTools/Program.cs	MainForm refactored to validate packets during intake, queue results in ConcurrentQueue, and flush periodically via timer to UI thread with batch updates. Splits Packets tab into sub-tabs ("Log" and "Issues"), applies owner-drawn rendering with color stripes, unifies context menus and clipboard copy across listboxes. Program.cs wires PacketValidationService dependency into MainForm constructor.

Sequence Diagram

sequenceDiagram
    participant UI as MainForm UI
    participant PLS as PacketLogService
    participant Val as PacketValidationService
    participant Queue as ConcurrentQueue
    participant Timer as Update Timer

    PLS->>UI: PacketLogged event
    activate UI
    UI->>Val: Validate(packet)
    activate Val
    Val->>Val: Reflect on PacketBase types
    Val->>Val: Extract header token
    Val->>Val: Attempt deserialization
    Val-->>UI: PacketValidationIssue or null
    deactivate Val
    UI->>Queue: Enqueue packet & issue
    deactivate UI
    
    Timer->>Queue: Periodic flush
    activate Queue
    Queue->>UI: Batch add to log listbox
    Queue->>UI: Batch add to issues listbox
    Queue->>UI: Update failed headers
    deactivate Queue

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~55 minutes

Poem

🐰 With whiskers twitching, I've built a fine sight,
Packets now validated—wrong tags set right!
Queues dance in thread-safe steps, timer flushes with care,
Issues tab sparkles with colors so fair!
A bunny's delight—validation takes flight! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/packet-log-perf-and-tags

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}