feat: add Qnamli2Packet and ServerPackets.Player.BpmPacket (17.5.0)#453
Merged
erwan-joly merged 1 commit intomasterfrom Apr 24, 2026
Merged
feat: add Qnamli2Packet and ServerPackets.Player.BpmPacket (17.5.0)#453erwan-joly merged 1 commit intomasterfrom
erwan-joly merged 1 commit intomasterfrom
Conversation
- `qnamli2 100 #rl 1646 13 2514 Gladi` — new class, mirrors QnamliPacket with an extra trailing string. - `bpm 0 0 0` server-side — compact 3-byte marker, distinct from the existing client-side BpmPacket that ships the full quest list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThis pull request introduces two new server packet implementations ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two missing schemas that were flagged by the validator:
Qnamli2Packet— matchesqnamli2 100 #rl 1646 13 2514 Gladi.ServerPackets.Player.BpmPacket— matches the compactbpm 0 0 0server form, distinct from the existing client-side request packet.Packets directory placement confirmed: all ClientPackets.* live under src/NosCore.Packets/ClientPackets/ and all ServerPackets.* under src/NosCore.Packets/ServerPackets/ (scanned tree, no mismatches).
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores