This repository was archived by the owner on Dec 11, 2025. It is now read-only.
T7 custom model attributes ENG-889#20
Merged
Merged
Conversation
Contributor
Author
|
Tests are failing due to API key probably |
Contributor
Author
|
Only one test failure due to replicate server side error |
acompa
approved these changes
Aug 26, 2024
Contributor
acompa
left a comment
acompa
left a comment
There was a problem hiding this comment.
A small nit on docs, but will approve to unblock you.
Comment on lines
+55
to
+58
| context_length: Optional[int] = None, | ||
| input_price: Optional[float] = None, | ||
| output_price: Optional[float] = None, | ||
| latency: Optional[float] = None, |
Contributor
There was a problem hiding this comment.
Can you please add these to the class docs as well?
Contributor
Author
There was a problem hiding this comment.
Yup added. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom model attributes to SDK (also sneak in the previous_session param)