Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

Adding NotDiamondRoutedRunnable to toolkit. [ENG-1106]#29

Merged
acompa merged 3 commits into
mainfrom
a9-toolkit-langchain
Sep 11, 2024
Merged

Adding NotDiamondRoutedRunnable to toolkit. [ENG-1106]#29
acompa merged 3 commits into
mainfrom
a9-toolkit-langchain

Conversation

@acompa
Copy link
Copy Markdown
Contributor

@acompa acompa commented Sep 10, 2024

Brought over from langchain-ai/langchain#25897 so that we can ship and share with our users for the moment.

Also includes unit tests and integration tests from that PR, which were all passing except for some minor linting issues.

@acompa acompa requested a review from r0ymanesco September 10, 2024 21:55
Copy link
Copy Markdown
Contributor

@r0ymanesco r0ymanesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the test failed because there is another test_language.py in the test suite. Might want to rename

Copy link
Copy Markdown
Contributor

@r0ymanesco r0ymanesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@acompa
Copy link
Copy Markdown
Contributor Author

acompa commented Sep 11, 2024

Tests failing on LLM integrations unrelated to this change. Merging.

@acompa acompa merged commit 9f10831 into main Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants