This repository was archived by the owner on Dec 11, 2025. It is now read-only.
add support for o1/o1-mini ENG-1114#32
Merged
Merged
Conversation
acompa
reviewed
Sep 24, 2024
Contributor
acompa
left a comment
acompa
left a comment
There was a problem hiding this comment.
Clarifying some stylistic q's, but otherwise only want to block until we confirm including the wheels for SQLAlchemy.
Comment on lines
+92
to
+95
| o1_PREVIEW = ("openai", "o1-preview") | ||
| o1_PREVIEW_2024_09_12 = ("openai", "o1-preview-2024-09-12") | ||
| o1_MINI = ("openai", "o1-mini") | ||
| o1_MINI_2024_09_12 = ("openai", "o1-mini-2024-09-12") |
Contributor
There was a problem hiding this comment.
Same as above:
Suggested change
| o1_PREVIEW = ("openai", "o1-preview") | |
| o1_PREVIEW_2024_09_12 = ("openai", "o1-preview-2024-09-12") | |
| o1_MINI = ("openai", "o1-mini") | |
| o1_MINI_2024_09_12 = ("openai", "o1-mini-2024-09-12") | |
| O1_PREVIEW = ("openai", "o1-preview") | |
| O1_PREVIEW_2024_09_12 = ("openai", "o1-preview-2024-09-12") | |
| O1_MINI = ("openai", "o1-mini") | |
| O1_MINI_2024_09_12 = ("openai", "o1-mini-2024-09-12") |
| optional = true | ||
| python-versions = ">=3.7" | ||
| files = [ | ||
| {file = "SQLAlchemy-2.0.34-cp310-cp310-macosx_10_9_x86_64.whl", hash = "sha256:95d0b2cf8791ab5fb9e3aa3d9a79a0d5d51f55b6357eecf532a120ba3b5524db"}, |
Contributor
There was a problem hiding this comment.
Did you intend to include these wheels here?
Contributor
Author
There was a problem hiding this comment.
This must have been added when I updated openai. I don't know why it was ever a dependency but clearly it was already there before I ran the update
Contributor
Author
There was a problem hiding this comment.
It's actually a dependency of langchain
Contributor
There was a problem hiding this comment.
Well if langchain + poetry brought them in they must be intentional 🤷🏼
acompa
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for o1 and o1-mini