This repository was archived by the owner on Dec 11, 2025. It is now read-only.
add feature parity in client methods ENG-891#9
Merged
Conversation
r0ymanesco
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
acompa
approved these changes
Jul 31, 2024
Contributor
acompa
left a comment
acompa
left a comment
There was a problem hiding this comment.
Looks great, thank you for the quick turnaround!
| LLMConfig: the best LLM selected by the router | ||
| """ | ||
|
|
||
| if model is not None: |
Contributor
There was a problem hiding this comment.
We don't need this code branch? That was my error, if not.
Contributor
There was a problem hiding this comment.
Ah, confirming you moved it into the child method.
Contributor
Author
There was a problem hiding this comment.
Yea I moved it to the corresponding invoke and ainvoke methods since create and acreate are just wrappers for them anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing params in
stream,astream,invoke,ainvokemethods