Skip to content

minor improvements #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NotAShelf merged 2 commits into from
Dec 1, 2025
Merged

minor improvements #30

NotAShelf merged 2 commits into from
Dec 1, 2025

Conversation

@imnotpoz
Copy link
Contributor

@imnotpoz imnotpoz commented Dec 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Performance Comparison →

Total Elapsed Time: 767.09µs → 774.85µs (+1.0%)

Profiling Mode: timing - Execution duration of functions.

+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| Function                                      | Calls            | Avg                            | P95                            | Total                          | % Total                      |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::main                              | 1 → 1 (+0.0%)    | 80.08µs → 91.14µs (+13.8%)     | 80.13µs → 91.20µs (+13.8%)     | 80.08µs → 91.14µs (+13.8%)     | 100.00% → 100.00% (+0.0%)    |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::system::get_memory_usage          | 1 → 1 (+0.0%)    | 18.55µs → 23.78µs (+28.2%) ⚠️  | 18.56µs → 23.79µs (+28.2%) ⚠️  | 18.55µs → 23.78µs (+28.2%) ⚠️  | 23.16% → 26.09% (+12.7%)     |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::print_system_info                 | 1 → 1 (+0.0%)    | 13.90µs → 16.33µs (+17.4%)     | 13.90µs → 16.33µs (+17.4%)     | 13.90µs → 16.33µs (+17.4%)     | 17.36% → 17.91% (+3.2%)      |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::system::parse_memory_info         | 1 → 1 (+0.0%)    | 15.44µs → 15.82µs (+2.5%)      | 15.45µs → 15.82µs (+2.4%)      | 15.44µs → 15.82µs (+2.5%)      | 19.28% → 17.36% (-10.0%)     |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::release::get_os_pretty_name       | 1 → 1 (+0.0%)    | 10.59µs → 10.65µs (+0.5%)      | 10.60µs → 10.65µs (+0.5%)      | 10.59µs → 10.65µs (+0.5%)      | 13.22% → 11.68% (-11.6%)     |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::release::get_system_info          | 1 → 1 (+0.0%)    | 4.71µs → 6.00µs (+27.4%) ⚠️    | 4.71µs → 6.00µs (+27.3%) ⚠️    | 4.71µs → 6.00µs (+27.4%) ⚠️    | 5.87% → 6.57% (+11.9%)       |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::system::get_root_disk_usage       | 1 → 1 (+0.0%)    | 3.73µs → 3.69µs (-1.3%)        | 3.73µs → 3.69µs (-1.3%)        | 3.73µs → 3.69µs (-1.3%)        | 4.66% → 4.04% (-13.3%)       |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::uptime::get_current               | 1 → 1 (+0.0%)    | 3.80µs → 3.28µs (-13.7%)       | 3.81µs → 3.29µs (-13.7%)       | 3.80µs → 3.28µs (-13.7%)       | 4.75% → 3.60% (-24.2%) 🚀    |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::system::get_username_and_hostname | 1 → 1 (+0.0%)    | 4.56µs → 2.54µs (-44.3%) 🚀    | 4.56µs → 2.54µs (-44.3%) 🚀    | 4.56µs → 2.54µs (-44.3%) 🚀    | 5.69% → 2.78% (-51.1%) 🚀    |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::desktop::get_desktop_info         | 1 → 1 (+0.0%)    | 1.83µs → 1.76µs (-3.8%)        | 1.83µs → 1.76µs (-3.8%)        | 1.83µs → 1.76µs (-3.8%)        | 2.28% → 1.92% (-15.8%)       |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::system::get_shell                 | 1 → 1 (+0.0%)    | 1.20µs → 1.25µs (+3.8%)        | 1.20µs → 1.25µs (+3.8%)        | 1.20µs → 1.25µs (+3.8%)        | 1.49% → 1.36% (-8.7%)        |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| microfetch::colors::print_dots                | 1 → 1 (+0.0%)    | 865.00ns → 784.00ns (-9.4%)    | 865.00ns → 784.00ns (-9.4%)    | 865.00ns → 784.00ns (-9.4%)    | 1.08% → 0.86% (-20.4%) 🚀    |
+-----------------------------------------------+------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+

Generated with hotpath-rs

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 774850,
  "description": "Execution duration of functions.",
  "caller_name": "microfetch::main",
  "output": {
    "microfetch::main": {
      "calls": 1,
      "avg": 91139,
      "p95": 91199,
      "total": 91139,
      "percent_total": 10000
    },
    "microfetch::print_system_info": {
      "calls": 1,
      "avg": 16327,
      "p95": 16327,
      "total": 16327,
      "percent_total": 1791
    },
    "microfetch::system::get_root_disk_usage": {
      "calls": 1,
      "avg": 3685,
      "p95": 3685,
      "total": 3685,
      "percent_total": 404
    },
    "microfetch::system::get_memory_usage": {
      "calls": 1,
      "avg": 23782,
      "p95": 23791,
      "total": 23782,
      "percent_total": 2609
    },
    "microfetch::system::get_username_and_hostname": {
      "calls": 1,
      "avg": 2541,
      "p95": 2541,
      "total": 2541,
      "percent_total": 278
    },
    "microfetch::release::get_system_info": {
      "calls": 1,
      "avg": 5996,
      "p95": 5999,
      "total": 5996,
      "percent_total": 657
    },
    "microfetch::system::get_shell": {
      "calls": 1,
      "avg": 1247,
      "p95": 1247,
      "total": 1247,
      "percent_total": 136
    },
    "microfetch::uptime::get_current": {
      "calls": 1,
      "avg": 3284,
      "p95": 3285,
      "total": 3284,
      "percent_total": 360
    },
    "microfetch::colors::print_dots": {
      "calls": 1,
      "avg": 784,
      "p95": 784,
      "total": 784,
      "percent_total": 86
    },
    "microfetch::system::parse_memory_info": {
      "calls": 1,
      "avg": 15823,
      "p95": 15823,
      "total": 15823,
      "percent_total": 1736
    },
    "microfetch::release::get_os_pretty_name": {
      "calls": 1,
      "avg": 10647,
      "p95": 10647,
      "total": 10647,
      "percent_total": 1168
    },
    "microfetch::desktop::get_desktop_info": {
      "calls": 1,
      "avg": 1756,
      "p95": 1756,
      "total": 1756,
      "percent_total": 192
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 767094,
  "description": "Execution duration of functions.",
  "caller_name": "microfetch::main",
  "output": {
    "microfetch::uptime::get_current": {
      "calls": 1,
      "avg": 3804,
      "p95": 3805,
      "total": 3804,
      "percent_total": 475
    },
    "microfetch::system::get_memory_usage": {
      "calls": 1,
      "avg": 18548,
      "p95": 18559,
      "total": 18548,
      "percent_total": 2316
    },
    "microfetch::colors::print_dots": {
      "calls": 1,
      "avg": 865,
      "p95": 865,
      "total": 865,
      "percent_total": 108
    },
    "microfetch::system::get_shell": {
      "calls": 1,
      "avg": 1201,
      "p95": 1201,
      "total": 1201,
      "percent_total": 149
    },
    "microfetch::release::get_system_info": {
      "calls": 1,
      "avg": 4708,
      "p95": 4711,
      "total": 4708,
      "percent_total": 587
    },
    "microfetch::system::get_username_and_hostname": {
      "calls": 1,
      "avg": 4558,
      "p95": 4559,
      "total": 4558,
      "percent_total": 569
    },
    "microfetch::desktop::get_desktop_info": {
      "calls": 1,
      "avg": 1826,
      "p95": 1826,
      "total": 1826,
      "percent_total": 228
    },
    "microfetch::release::get_os_pretty_name": {
      "calls": 1,
      "avg": 10594,
      "p95": 10599,
      "total": 10594,
      "percent_total": 1322
    },
    "microfetch::system::get_root_disk_usage": {
      "calls": 1,
      "avg": 3732,
      "p95": 3733,
      "total": 3732,
      "percent_total": 466
    },
    "microfetch::system::parse_memory_info": {
      "calls": 1,
      "avg": 15443,
      "p95": 15447,
      "total": 15443,
      "percent_total": 1928
    },
    "microfetch::main": {
      "calls": 1,
      "avg": 80077,
      "p95": 80127,
      "total": 80077,
      "percent_total": 10000
    },
    "microfetch::print_system_info": {
      "calls": 1,
      "avg": 13902,
      "p95": 13903,
      "total": 13902,
      "percent_total": 1736
    }
  }
}

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Performance Comparison →

Total Elapsed Time: 779.11µs → 791.94µs (+1.6%)

Profiling Mode: alloc - Cumulative allocations during each function call (including nested calls).

+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| Function                                      | Calls            | Avg                        | P95                        | Total                      | % Total                      |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::main                              | 1 → 1 (+0.0%)    | 2.8 KB → 2.8 KB (+0.1%)    | 2.8 KB → 2.8 KB (+0.1%)    | 2.8 KB → 2.8 KB (+0.1%)    | 100.00% → 100.00% (+0.0%)    |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::print_system_info                 | 1 → 1 (+0.0%)    | 2.4 KB → 2.4 KB (+0.1%)    | 2.4 KB → 2.4 KB (+0.1%)    | 2.4 KB → 2.4 KB (+0.1%)    | 86.12% → 86.13% (+0.0%)      |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::system::get_memory_usage          | 1 → 1 (+0.0%)    | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 2.24% → 2.24% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::system::get_root_disk_usage       | 1 → 1 (+0.0%)    | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 2.24% → 2.24% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::colors::print_dots                | 1 → 1 (+0.0%)    | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 64 B → 64 B (+0.0%)        | 2.24% → 2.24% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::system::get_username_and_hostname | 1 → 1 (+0.0%)    | 45 B → 45 B (+0.0%)        | 45 B → 45 B (+0.0%)        | 45 B → 45 B (+0.0%)        | 1.57% → 1.57% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::release::get_system_info          | 1 → 1 (+0.0%)    | 32 B → 32 B (+0.0%)        | 32 B → 32 B (+0.0%)        | 32 B → 32 B (+0.0%)        | 1.12% → 1.12% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::uptime::get_current               | 1 → 1 (+0.0%)    | 32 B → 32 B (+0.0%)        | 32 B → 32 B (+0.0%)        | 32 B → 32 B (+0.0%)        | 1.12% → 1.12% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::release::get_os_pretty_name       | 1 → 1 (+0.0%)    | 18 B → 18 B (+0.0%)        | 18 B → 18 B (+0.0%)        | 18 B → 18 B (+0.0%)        | 0.63% → 0.63% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::desktop::get_desktop_info         | 1 → 1 (+0.0%)    | 17 B → 17 B (+0.0%)        | 17 B → 17 B (+0.0%)        | 17 B → 17 B (+0.0%)        | 0.59% → 0.59% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::system::get_shell                 | 1 → 1 (+0.0%)    | 13 B → 13 B (+0.0%)        | 13 B → 13 B (+0.0%)        | 13 B → 13 B (+0.0%)        | 0.45% → 0.45% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+
| microfetch::system::parse_memory_info         | 1 → 1 (+0.0%)    | 0 B → 0 B (+0.0%)          | 0 B → 0 B (+0.0%)          | 0 B → 0 B (+0.0%)          | 0.00% → 0.00% (+0.0%)        |
+-----------------------------------------------+------------------+----------------------------+----------------------------+----------------------------+------------------------------+

Generated with hotpath-rs

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "alloc",
  "total_elapsed": 791944,
  "description": "Cumulative allocations during each function call (including nested calls).",
  "caller_name": "microfetch::main",
  "output": {
    "microfetch::system::get_shell": {
      "calls": 1,
      "avg": 13,
      "p95": 13,
      "total": 13,
      "percent_total": 45
    },
    "microfetch::main": {
      "calls": 1,
      "avg": 2857,
      "p95": 2857,
      "total": 2857,
      "percent_total": 10000
    },
    "microfetch::system::get_memory_usage": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::system::get_username_and_hostname": {
      "calls": 1,
      "avg": 45,
      "p95": 45,
      "total": 45,
      "percent_total": 157
    },
    "microfetch::print_system_info": {
      "calls": 1,
      "avg": 2461,
      "p95": 2461,
      "total": 2461,
      "percent_total": 8613
    },
    "microfetch::system::parse_memory_info": {
      "calls": 1,
      "avg": 0,
      "p95": 0,
      "total": 0,
      "percent_total": 0
    },
    "microfetch::release::get_system_info": {
      "calls": 1,
      "avg": 32,
      "p95": 32,
      "total": 32,
      "percent_total": 112
    },
    "microfetch::release::get_os_pretty_name": {
      "calls": 1,
      "avg": 18,
      "p95": 18,
      "total": 18,
      "percent_total": 63
    },
    "microfetch::system::get_root_disk_usage": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::uptime::get_current": {
      "calls": 1,
      "avg": 32,
      "p95": 32,
      "total": 32,
      "percent_total": 112
    },
    "microfetch::colors::print_dots": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::desktop::get_desktop_info": {
      "calls": 1,
      "avg": 17,
      "p95": 17,
      "total": 17,
      "percent_total": 59
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "alloc",
  "total_elapsed": 779114,
  "description": "Cumulative allocations during each function call (including nested calls).",
  "caller_name": "microfetch::main",
  "output": {
    "microfetch::release::get_os_pretty_name": {
      "calls": 1,
      "avg": 18,
      "p95": 18,
      "total": 18,
      "percent_total": 63
    },
    "microfetch::system::get_shell": {
      "calls": 1,
      "avg": 13,
      "p95": 13,
      "total": 13,
      "percent_total": 45
    },
    "microfetch::release::get_system_info": {
      "calls": 1,
      "avg": 32,
      "p95": 32,
      "total": 32,
      "percent_total": 112
    },
    "microfetch::print_system_info": {
      "calls": 1,
      "avg": 2459,
      "p95": 2459,
      "total": 2459,
      "percent_total": 8612
    },
    "microfetch::main": {
      "calls": 1,
      "avg": 2855,
      "p95": 2855,
      "total": 2855,
      "percent_total": 10000
    },
    "microfetch::system::get_memory_usage": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::colors::print_dots": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::uptime::get_current": {
      "calls": 1,
      "avg": 32,
      "p95": 32,
      "total": 32,
      "percent_total": 112
    },
    "microfetch::system::get_root_disk_usage": {
      "calls": 1,
      "avg": 64,
      "p95": 64,
      "total": 64,
      "percent_total": 224
    },
    "microfetch::system::get_username_and_hostname": {
      "calls": 1,
      "avg": 45,
      "p95": 45,
      "total": 45,
      "percent_total": 157
    },
    "microfetch::system::parse_memory_info": {
      "calls": 1,
      "avg": 0,
      "p95": 0,
      "total": 0,
      "percent_total": 0
    },
    "microfetch::desktop::get_desktop_info": {
      "calls": 1,
      "avg": 17,
      "p95": 17,
      "total": 17,
      "percent_total": 59
    }
  }
}

@NotAShelf NotAShelf merged commit a3b169b into NotAShelf:main Dec 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imnotpoz @NotAShelf