Ctrl+F Find in Docs will show not-on-page results.

[fizykz]

I have confirmed that this is a bug related to nvf

• This is a bug, and not an user error or a support request. I understand that my issue will be closed if it is not a bug in nvf.
• I have checked the issues tab and confirmed that my issue has not yet been reported. I understand that my issue will be closed if it is a duplicate.

Description

When searching options on the Doc website, it is reasonable to want to further browse options or refine results by using Ctrl+F to find. However, for some reason, this gives many irrelevant results that are not on page. An example is shown in image, where it can be seen that an option from Typst Concealer appears despite the fact that it has no mention of the searched keyword "noice."

Installation Method

Standalone (flake outputs, nix profile install, etc.)

Installation Method (Other)

No response

nvf Version

Docs v0.9

Reproduction steps

• Go to options search on docs.
• Search "noice" (or other keywords)
• Ctrl+F
• Search anything
• You'll see many more results than what are on page, typically.

Expected behavior

Only display what's on page.

Actual Behavior

Currently displaying things not on page.

System Information

Firefox 146.0.1 64 bit
Firefox for NixOS
Nixpkgs revision:  ffbc9f8cbaacfb331b6017d5a5abb21a492c9a38

Relevant log output

N/A

[NotAShelf]

This is probably because we hide filtered entries via CSS rather than modifying the list for each search. This is the performant option, but I guess not the correct one.

I think the most appropriate solution that doesn't make the search widget a complete mess would be hijacking the Ctrl+F search and use our filtered search result. Though I am pretty sure most browsers allow invoking the search without a keybind so that might fall flat. I'll see what I can do.

[NotAShelf]

The solution turned out to be easier than I've expected. This'll be fixed in the next NDG release, but keeping it open until we bump the NDG input.