Conversation
NotAShelf
left a comment
There was a problem hiding this comment.
A few notes regarding the correctness of the implementation and some formatting nits.
I'm not opposed to merging, but we should probably avoid polluting the closure for TS users while they haven't opted in to use Vue explicitly. The vue_ls server addition is fine, but I believe the plugin should not be added by default. I for one never use Vue anymore, but this would pull the LSP anyway and subject me to more rebuilds & cache hits for no reason.
You'll also want to update the v0.9 changelog (in docs/release-notes) with an entry.
|
I've implemented the changes you requested. My bad on the formatting, I forgot to use alejandra instead of nixfmt. I'm pretty new to nix so bare with me if I make some silly mistakes or assumptions. ;^^ |
| formatType = | ||
| enum (attrNames formats); |
There was a problem hiding this comment.
this type is wrong and errors when evaluating, since you expect a single value, but you're setting a list above.
see here:
https://github.com/miaapancake/nvf/blob/533135a95d147110e581da686975cd0312e4aac6/modules/plugins/languages/vue.nix#L67-L73
Looking at what you've been setting in defaultFormat above, you probably want this:
| formatType = | |
| enum (attrNames formats); | |
| formatType = | |
| nonEmptyListOf (enum (attrNames formats)); |
In this PR I've added support for vue in the ts_ls language server.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.