theme: solarized-osaka update npins & style opt#1367
Draft
taylrfnt wants to merge 2 commits intoNotAShelf:mainfrom
Draft
theme: solarized-osaka update npins & style opt#1367taylrfnt wants to merge 2 commits intoNotAShelf:mainfrom
taylrfnt wants to merge 2 commits intoNotAShelf:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1336
This adds support for styles to be passed into configuration for
solarized-osakatheme.Important
As with other themes, introduction of style options where one does not exist is a breaking change. I don't know if we want to phase this in or just assume folks on
mainare ok with breaking changes.Sanity Checking
nix fmt).#nix(default package).#maximal1.#docs-html(manual, must build) 2.#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.
Footnotes
maximalbuilds successfully, but the runtime fails due to some of the unresolved treesitter issues. nothing related to this theme change that I could see. ↩docs-htmlwas not marked off since it fails with the following error on my system. I'll try and look into it when I get some time.error: attribute 'aarch64-darwin' missing at /nix/store/ar8i4qgra87q7js4yvgqh7srciicxhkr-source/docs/manual.nix:13:8. ↩