Skip to content

theme: solarized-osaka update npins & style opt#1367

Draft
taylrfnt wants to merge 2 commits intoNotAShelf:mainfrom
taylrfnt:solarized-osaka-update
Draft

theme: solarized-osaka update npins & style opt#1367
taylrfnt wants to merge 2 commits intoNotAShelf:mainfrom
taylrfnt:solarized-osaka-update

Conversation

@taylrfnt
Copy link
Contributor

Addresses #1336

This adds support for styles to be passed into configuration for solarized-osaka theme.

Important

As with other themes, introduction of style options where one does not exist is a breaking change. I don't know if we want to phase this in or just assume folks on main are ok with breaking changes.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal1
    • .#docs-html (manual, must build) 2
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Footnotes

  1. maximal builds successfully, but the runtime fails due to some of the unresolved treesitter issues. nothing related to this theme change that I could see.

  2. docs-html was not marked off since it fails with the following error on my system. I'll try and look into it when I get some time. error: attribute 'aarch64-darwin' missing at /nix/store/ar8i4qgra87q7js4yvgqh7srciicxhkr-source/docs/manual.nix:13:8.

@github-actions
Copy link

🚀 Live preview deployed from dacc727

View it here:

Debug Information

Triggered by: taylrfnt

HEAD at: solarized-osaka-update

Reruns: 1974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant