docs: work around ndg bug where closing tip delimiter tag breaks things#1375
docs: work around ndg bug where closing tip delimiter tag breaks things#1375JamyGolden wants to merge 1 commit intoNotAShelf:mainfrom
Conversation
|
As stated previously, this is not an actual fix; it'll be undid automagically when a formatter is ran, and the PR will become meaningless. I appreciate the effort, however, this has to be fixed in NDG as it's a critical bug in the Edit: I'll be looking into fixing this in NDG once my current NDG work is done; I've been busy with the 12 trillion projects that I've taken up for some reason, so it's taking some time. |
03ebbe0 to
48fd16f
Compare
|
Not sure where that was stated previously, the tickets I linked to in this PR don't mention that. There are other ways to fix this in nvf that don't include an empty line at the end of a file which formatters might remove, but fixing it directly in ndg is obviously the best way to do it. Thanks for the effort you put into the open source community. |
I looked into the bugs #1290 and #1327 and found the issue lay with ndg and I created an issue mentioning the problem: feel-co/ndg#106
This PR fixes the bugs mentioned in the issues above and is a work around the ndg bug
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwin