Skip to content

Version 0.2.0#8

Merged
neocotic merged 24 commits intomasterfrom
develop
Feb 11, 2017
Merged

Version 0.2.0#8
neocotic merged 24 commits intomasterfrom
develop

Conversation

@neocotic
Copy link
Copy Markdown
Member

@neocotic neocotic commented Jan 18, 2017

Here's a summary of the changes for 0.2.0:

@neocotic neocotic added this to the 0.2.0 milestone Jan 18, 2017
Drop support for Java 7
Support nested arrays and circular references in DefaultArrayFormatter
* added initial support for multiple locales

* attempting to fix broken build
@neocotic neocotic self-assigned this Feb 7, 2017
@neocotic
Copy link
Copy Markdown
Member Author

neocotic commented Feb 9, 2017

I will also want to make sure that I add a changelog to the project and also update the copyright year for all files to 2017.

@neocotic
Copy link
Copy Markdown
Member Author

I want to experiment with benchmarking/profiling the new Services stuff as I want to make sure that using SPI won't incur a big performance hit. If it does, I'll consider implementing caching for SPI lookups and/or use-case specific caching.

@neocotic
Copy link
Copy Markdown
Member Author

I might also add the ability to further chain verifications on to the back of each other by adding and methods to CustomVerifier that provide a similar API to that of Verifier, except that they create a modified copy of the current Verification to avoid additional SPI lookups.

Here's what it could look like, based on the example in the README:

package com.example.form;

import io.skelp.verifier.Verifier;

public class LoginForm implements Form {

    UserService userService;

    @Override
    public void handle(Map<String, String> data) {
        Verifier.verify(data)
            .containAllKeys("username", "password");
            .and(data.get("username"), "username")
                .not().blank();
            .and(data.get("password"), "password")
                .not().empty()
                .alphanumeric();

        userService.login(data);
    }
}

The only thing is that this would obviously only be able to chain built-in verifiers and match the API of our Verifier. I think that this is acceptable though.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@f5a86df). Click here to learn what that means.

@@           Coverage Diff           @@
##             master     #8   +/-   ##
=======================================
  Coverage          ?   100%           
  Complexity        ?   1013           
=======================================
  Files             ?     54           
  Lines             ?   1629           
  Branches          ?    222           
=======================================
  Hits              ?   1629           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ Complexity Δ
...main/java/io/skelp/verifier/VerifierException.java 100% <ø> (ø) 4 <ø> (?)
...ava/io/skelp/verifier/type/CollectionVerifier.java 100% <ø> (ø) 3 <ø> (?)
...ain/java/io/skelp/verifier/type/ArrayVerifier.java 100% <ø> (ø) 7 <ø> (?)
.../java/io/skelp/verifier/type/CalendarVerifier.java 100% <ø> (ø) 2 <ø> (?)
...in/java/io/skelp/verifier/type/ObjectVerifier.java 100% <ø> (ø) 1 <ø> (?)
...ava/io/skelp/verifier/type/ComparableVerifier.java 100% <ø> (ø) 1 <ø> (?)
...main/java/io/skelp/verifier/type/DateVerifier.java 100% <ø> (ø) 3 <ø> (?)
...ain/java/io/skelp/verifier/type/ShortVerifier.java 100% <100%> (ø) 25 <ø> (?)
...elp/verifier/type/base/BaseCollectionVerifier.java 100% <100%> (ø) 25 <6> (?)
...elp/verifier/service/ServiceNotFoundException.java 100% <100%> (ø) 1 <1> (?)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a86df...d467ae9. Read the comment docs.

@neocotic neocotic merged commit 83e60aa into master Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant