Skip to content

Respect global minimum item price by disabling default per-item override examples#38

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-minimum-price-requirement
Draft

Respect global minimum item price by disabling default per-item override examples#38
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-minimum-price-requirement

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

Changing settings.min-price-per-item could still appear ineffective because default per-item-price entries in config.yml imposed higher material-specific minimums (including DIAMOND: 10). This made minimum-price behavior look hardcoded despite config changes.

  • Config default behavior

    • Commented out active example entries under per-item-price in the shipped config.yml.
    • Kept them as documented examples, but no longer applied by default at runtime.
  • Runtime impact

    • Global settings.min-price-per-item now applies unless operators explicitly enable per-item overrides.
    • Existing override mechanism remains unchanged for servers that intentionally configure material-level limits.
per-item-price:
  # SHULKER_BOX:
  #   min-price-per-item: 20
  #   max-price-per-item: 100
  # DIAMOND:
  #   min-price-per-item: 10
  #   max-price-per-item: 500

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • jitpack.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • maven.devs.beer
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • nexus.phoenixdevt.fr
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • repo.codemc.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • repo.extendedclip.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • repo.nexomc.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)
  • repo.papermc.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.16/boot/plexus-classworlds-2.11.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.16/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.16 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.16/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/NOrder/NOrder org.codehaus.plexus.classworlds.launcher.Launcher -q test (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 21, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix minimum price restriction to allow values lower than 10 Respect global minimum item price by disabling default per-item override examples May 21, 2026
Copilot AI requested a review from NotPatch May 21, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant set minimum price lower than 10

2 participants