fix: conversation filter and detail UI improvements#147
Merged
NotYuSheng merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
- Remove globe/cpu icons from Country and Device Type filter section headers - Add InfoPopover to Device Type filter (with tooltip about confidence/evidence hover) - Align Country and Device Type badge styles with other filter pills (filter-pill class) - Filter out empty country codes to prevent blank badges - Show "Internal" label for private IPs with no geo data in conversation detail - Remove emoji icons from device type badges in filter panel and conversation detail Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request removes device type icons from the conversation detail and filter panels, updates the styling of filter pills, and introduces logic to identify and display 'Internal' status for private IP addresses when geographic information is unavailable. Review feedback suggests optimizing the private IP detection regex to include IPv6 support, refining the country filter logic to avoid redundant string splitting, correcting the help text for device type badges to match the actual click interaction, and using a dynamic text color function for better accessibility and contrast.
- Combine isPrivateIp regexes into one expression and add IPv6 ULA/link-local support - Avoid redundant split in country filter by mapping before filtering - Fix device type tooltip: "hover" → "click" to match actual interaction - Use getTextColor(bg) for device type badge text color instead of hardcoded #fff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code