feat: nDPI JA3/JA3S TLS fingerprints per conversation#63
Merged
NotYuSheng merged 2 commits intomainfrom Mar 28, 2026
Merged
Conversation
- V8 migration: add ja3_client VARCHAR(32) and ja3_server VARCHAR(32) to conversations - ConversationEntity: add JA3_HASH_LENGTH = 32 constant; ja3Client and ja3Server fields - NdpiService: add JA3C and JA3S regex patterns, parse [JA3C: hash] and [JA3S: hash] from ndpiReader -v 2 output in the same single pass - Propagate ja3Client/ja3Server through PcapParserService.ConversationInfo, ConversationResponse, ConversationDetailResponse, and all AnalysisService builders - Frontend: ja3Client/ja3Server on Conversation type and conversationService mapping - ConversationDetail: show JA3 Client and JA3S Server hashes in monospace code tags when present (TLS flows only) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements JA3 client and server fingerprinting by updating the database schema, backend entities, DTOs, and the nDPI parsing service. The frontend is also updated to display these fingerprints in the conversation detail view. Feedback includes suggestions to use existing constants in regex patterns to avoid magic numbers, refactor duplicated extraction logic into a helper method, and improve the readability of a long log statement.
- JA3C/JA3S patterns now use ConversationEntity.JA3_HASH_LENGTH constant instead of magic number 32 - Shorten nDPI enrichment log statement for readability - Extract repeated JA3 hash extraction logic into extractHash() helper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Summary
ja3_client VARCHAR(32)andja3_server VARCHAR(32)toconversations[JA3C: hash]and[JA3S: hash]fromndpiReader -v 2output in the same single pass (regex anchored to 32-char hex strings to avoid false positives);JA3_HASH_LENGTH = 32constant defined onConversationEntityConversationEntity,ConversationResponse,ConversationDetailResponse, and allAnalysisServicebuilder blocks expose both hashes<code>tags when present (TLS flows only)Test plan
zoom.pcap— click a TLS conversation and confirm JA3 Client / JA3S Server hashes appear in the detail panel🤖 Generated with Claude Code