feat: POST /reminder by sergiojoker11 · Pull Request #524 · Notifycal/backend

sergiojoker11 · 2025-04-11T17:01:52Z

dsiguero · 2025-04-13T17:24:38Z

Assuming I'm not in the wrong place again:

I think we should rename the endpoint to be POST /test-reminder (or /onboarding-test-reminder or something along those lines) to reflect it isn't part of the "regular processing".

sergiojoker11 · 2025-04-16T12:45:06Z

-                businessAddress:
-                  description: Business address
-                  type: string
+                business:


the reason for most changes in component-definitions cause this was outdated PATCH payload endpoint. My bad actually.

sergiojoker11 · 2025-04-16T13:42:51Z

    }
  }
+
+  protected getCommandRunner<T>(


Test it. Edit: it works against Localstack.

I copy-pasted this from src/services/common/base-store.ts. I don;t remember what the argument was to keep IndexStore and BaseStore totally separte. I was wonder if IndexStore might extend BaseStore.

sergiojoker11 · 2025-04-17T16:48:10Z

        content:
          application/json:
            schema:
-              type: object


this was outdated

sergiojoker11 · 2025-04-17T18:16:38Z

    "@middy/core": "^6.0.0",
    "@middy/http-cors": "^6.0.0",
-    "@notifycal/shared": "3.1.1",
+    "@notifycal/shared": "file:../shared/notifycal-shared-3.1.1.tgz",


bump once shared PR is merghed and released

sergiojoker11 · 2025-04-17T18:19:09Z

-            type: 'phone',
-            countryCode: 'ES',
-            phoneNumber: '666777888' as PhoneNumber
+        Calendars: [validCalendar],


This wasn;t strictly needed to implement the feature but I had to modify that part of the code base and I ended up making a mistake cause of this. Definetely it is way better to split the models completely. ie: api/persistance

dsiguero · 2025-04-18T09:41:29Z

    messageBody: string,
-    sender: MessageSender,
-    receiver: MessageReceiver,
+    sender: SenderStandardContact,


SenderStandardContact vs SenderNonStandardContact? what does Standard mean here?

SenderStandardContact -> phone in E164 OR RCSSenderId
SenderContact -> local phone number or RCSSender

…api.

…t out some other types

…eSentChanges

…een included within the data that gets sent over to Vonage to be read back when Vonage gives us updates.

🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.1...v0.29.0) (2025-04-18) ### Features * POST /reminder ([#524](#524)) ([0a5c36b](0a5c36b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dsiguero reviewed Apr 13, 2025

View reviewed changes

Comment thread src/lambdas/api/post-reminder/index.ts Outdated

sergiojoker11 force-pushed the feat/post-reminder branch 4 times, most recently from 1a124af to 1dca7e2 Compare April 15, 2025 19:14

sergiojoker11 commented Apr 15, 2025

View reviewed changes

Comment thread src/lambdas/api/post-reminder/index.ts Outdated

sergiojoker11 commented Apr 15, 2025

View reviewed changes

Comment thread tf/api_gateway.tf Outdated

sergiojoker11 commented Apr 16, 2025

View reviewed changes

sergiojoker11 force-pushed the feat/post-reminder branch 2 times, most recently from 4af9b76 to d6fd5c5 Compare April 16, 2025 13:39

sergiojoker11 commented Apr 16, 2025

View reviewed changes

sergiojoker11 force-pushed the feat/post-reminder branch 2 times, most recently from 4d3feef to 176d2a4 Compare April 16, 2025 17:33

sergiojoker11 commented Apr 16, 2025

View reviewed changes

Comment thread package.json Outdated

sergiojoker11 commented Apr 17, 2025

View reviewed changes

Comment thread openapi/component-definitions.yaml Outdated

sergiojoker11 commented Apr 17, 2025

View reviewed changes

Comment thread openapi/spec.yaml

content:

application/json:

schema:

type: object

Copy link
Copy Markdown

Member Author

sergiojoker11 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was outdated

sergiojoker11 force-pushed the feat/post-reminder branch from c68822c to 2406305 Compare April 17, 2025 18:15

sergiojoker11 commented Apr 17, 2025

View reviewed changes

Comment thread src/services/stores/user-live-index-store.ts Outdated

sergiojoker11 force-pushed the feat/post-reminder branch 4 times, most recently from a3876a4 to 7e436d5 Compare April 17, 2025 22:07

sergiojoker11 commented Apr 17, 2025

View reviewed changes

Comment thread src/services/stores/user-base-store.ts

dsiguero reviewed Apr 18, 2025

View reviewed changes

Comment thread tf/variables.tf

dsiguero reviewed Apr 18, 2025

View reviewed changes

Comment thread tf/lambda_shared.tf Outdated

dsiguero reviewed Apr 18, 2025

View reviewed changes

Comment thread src/utils/errors.ts

dsiguero reviewed Apr 18, 2025

View reviewed changes

sergiojoker11 and others added 24 commits April 19, 2025 01:07

refine store record models. Retrieve config through GET user profile …

a9d9f4e

…api.

absorb breaking changes from shared where models have been added. Sor…

dcc1798

…t out some other types

capitalize fields of bd model/types to avoid mistakes

5d2143b

update openapi api payload spec

3f3f791

renaming to DemoReminderToBeSent

f69bf29

ci(auto): generate docs and format

ab69229

refactor webhook a bit so it is easier to adapt it to demoReminderToB…

6a8d630

…eSentChanges

adapt vonage webhook to receive demoReminderToBeSent. eventType has b…

c15205f

…een included within the data that gets sent over to Vonage to be read back when Vonage gives us updates.

ci(auto): generate docs and format

7485473

ci(auto): generate docs and format

067c07f

ci(auto): generate docs and format

01a541e

ci(auto): generate docs and format

ac8885a

ci(auto): generate docs and format

e16a7a6

test new endpoint

e687a44

replace feature switch on data protection

e2ab9a8

ci(auto): generate docs and format

229f5ec

rename openapi spec component

9a4fd1f

ci(auto): generate docs and format

5cde877

extract identical vonage schemas and reuse

0876e30

add lambda layers to new lambda

d430a28

renaming

bf241da

bump to shared 4.0.0. Use UserBaseStore to get user config instead.

3fd414b

test errors

289ea10

fix shared version

f58d021

sergiojoker11 dismissed dsiguero’s stale review via f58d021 April 18, 2025 23:08

sergiojoker11 force-pushed the feat/post-reminder branch from 2767e7c to f58d021 Compare April 18, 2025 23:08

sergiojoker11 merged commit 0a5c36b into main Apr 18, 2025
4 checks passed

sergiojoker11 deleted the feat/post-reminder branch April 18, 2025 23:23

github-actions Bot mentioned this pull request Apr 18, 2025

chore(main): release 0.29.0 #572

Merged

Conversation

sergiojoker11 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dsiguero commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergiojoker11 Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergiojoker11 Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergiojoker11 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sergiojoker11 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

sergiojoker11 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

sergiojoker11 Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dsiguero Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

sergiojoker11 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sergiojoker11 commented Apr 11, 2025 •

edited

Loading

dsiguero commented Apr 13, 2025 •

edited

Loading

sergiojoker11 Apr 16, 2025 •

edited

Loading

sergiojoker11 Apr 16, 2025 •

edited

Loading

sergiojoker11 Apr 17, 2025 •

edited

Loading