feat!: add config to user model/type. Add types for contacts.#111
Merged
Conversation
…y that had to be fixed. Added models for phone contact
dsiguero
approved these changes
Apr 18, 2025
sergiojoker11
pushed a commit
that referenced
this pull request
Apr 18, 2025
🤖 I have created a release *beep* *boop* --- ## [4.0.0](v3.1.1...v4.0.0) (2025-04-18) ### ⚠ BREAKING CHANGES * add config to user model/type. Add types for contacts. ([#111](#111)) ### Features * add config to user model/type. Add types for contacts. ([#111](#111)) ([4beb054](4beb054)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sergiojoker11
added a commit
to Notifycal/backend
that referenced
this pull request
Apr 18, 2025
depends on: Notifycal/shared#111 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: dsiguero <26867647+dsiguero@users.noreply.github.com>
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add config to user model -> That introduced a circular dependency that had to be fixed. Same as before(we are gonna have this everythime types gets imported into schemas/templates/whatever). Types is meant to be a leave in the tree but sometimes, like in the reminders stuff you wanna define an schema based on data, if that data is somehow complex and import/use types you are screwed out. I cannot think of a definitive solution except for everything in the same /types or whatever but I dislike it very much cause it will make harder the code organization.
added models for phone contact'