feat: more info reminder config#136
Merged
Merged
Conversation
dsiguero
reviewed
May 14, 2025
| export const idpIdSchema = z.string().brand('IdpId'); | ||
| export const dateTimeSchema = z.string().datetime().brand('DateTime'); | ||
| export const timeZoneSchema = z.string().brand('TimeZone'); | ||
| export const idpIdSchema = z.string().max(128).brand('IdpId'); |
Member
There was a problem hiding this comment.
this is something I've been thinking (max). should we cap it for the form/onboarding stuff too?
BusinessName, BusinessAddress, etc etc
Member
Author
There was a problem hiding this comment.
(discussed on call)yes, let's limit fields ion frontend too.
dsiguero
reviewed
May 14, 2025
| @@ -96,7 +97,20 @@ export const reminderConfigSchema = z.object({ | |||
| business: z.object({ | |||
| name: z.string().min(1).brand('BusinessName'), | |||
Member
There was a problem hiding this comment.
TIL that .brand('BusinessName') and .transform(value => value as BusinessName) behave the same (because the TS type is a Brand)
Member
Author
There was a problem hiding this comment.
I will do it separetely once all PRs are merged - as discusssed over meet
dsiguero
approved these changes
May 14, 2025
dsiguero
reviewed
May 14, 2025
| senderContact: senderSchema, | ||
| language: languageCodeSchema, | ||
| timezone: timeZoneSchema, | ||
| companyIndustry: z.object({ |
Member
There was a problem hiding this comment.
This schema isn't for the API endpoint, right? I am a bit confused xD
dsiguero
reviewed
May 14, 2025
Member
dsiguero
left a comment
dsiguero
left a comment
There was a problem hiding this comment.
Estoy como Dinio, confundido xD
sergiojoker11
pushed a commit
that referenced
this pull request
May 15, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.1...v4.2.0) (2025-05-15) ### Features * more info reminder config ([#136](#136)) ([5db3112](5db3112)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sergiojoker11
added a commit
to Notifycal/backend
that referenced
this pull request
May 15, 2025
depends on : Notifycal/shared#136 extended ReminderConfig with: - language - timezone - T&C, privacy policy and marketing consent - company sector and size
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.