feat: 2 new user statuses. percentage schema and type#166
Merged
Conversation
dsiguero
reviewed
Jun 26, 2025
| .string() | ||
| .max(128) | ||
| .transform((data) => data as TimeZone); | ||
| export const percentageSchema = z |
Member
There was a problem hiding this comment.
Hmmmmm I'd argue that 150% of something is a valid percentage...
Maybe rename it to strictPercentageSchema?
Or ignore me xD
Member
Author
There was a problem hiding this comment.
I have removed the upper limit, it made no much sense
dsiguero
previously approved these changes
Jun 26, 2025
sergiojoker11
force-pushed
the
feat/stuff-for-subscriptions
branch
from
433804b to
3490b63
Compare
sergiojoker11
force-pushed
the
feat/stuff-for-subscriptions
branch
from
5fc8e12 to
fc529e8
Compare
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.