Skip to content

Fix collection traverse #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
transitive-bullshit merged 2 commits into from
Sep 18, 2025
Merged

Fix collection traverse #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443e10a
fix the bug of traversing no pages of collections
Euruson Aug 5, 2025
d39c7d6
change date-fns formatting string to remove warnings
Euruson Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/notion-utils/src/get-all-pages-in-space.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ export async function getAllPagesInSpace(
page.collection_query
)) {
for (const collectionData of Object.values(collectionViews)) {
const { blockIds } = collectionData

const { blockIds } =
collectionData?.collection_group_results || {}
if (blockIds) {
for (const collectionItemId of blockIds) {
void processPage(collectionItemId, depth + 1)
Expand Down
2 changes: 1 addition & 1 deletion packages/react-notion-x/src/third-party/collection-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function getCollectionGroups(
}

// TODO: review dates format based on value.type ('week'|'month'|'year')
queryValue = format(new Date(queryLabel), 'MMM d, YYY hh:mm aa')
queryValue = format(new Date(queryLabel), 'MMM d, yyyy hh:mm aa')
}

return {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-notion-x/src/third-party/eval-formula.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ function evalFunctionFormula(

case 'object':
if (value instanceof Date) {
return format(value as Date, 'MMM d, YYY')
return format(value as Date, 'MMM d, yyyy')
} else {
// shouldn't ever get here
return `${value}`
Expand Down
6 changes: 3 additions & 3 deletions packages/react-notion-x/src/third-party/property.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function PropertyImpl(props: IPropertyProps) {
}

if (content instanceof Date) {
content = format(content, 'MMM d, YYY hh:mm aa')
content = format(content, 'MMM d, yyyy hh:mm aa')
}
} catch {
// console.log('error evaluating formula', schema.formula, err)
Expand Down Expand Up @@ -437,15 +437,15 @@ export function PropertyImpl(props: IPropertyProps) {
const renderCreatedTimeValue = React.useMemo(
() =>
function CreatedTimeProperty() {
return format(new Date(block!.created_time), 'MMM d, YYY hh:mm aa')
return format(new Date(block!.created_time), 'MMM d, yyyy hh:mm aa')
},
[block]
)

const renderLastEditedTimeValue = React.useMemo(
() =>
function LastEditedTimeProperty() {
return format(new Date(block!.last_edited_time), 'MMM d, YYY hh:mm aa')
return format(new Date(block!.last_edited_time), 'MMM d, yyyy hh:mm aa')
},
[block]
)
Expand Down